Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slabtop: add -o/--once #69

Merged
merged 1 commit into from
Jul 3, 2024
Merged

slabtop: add -o/--once #69

merged 1 commit into from
Jul 3, 2024

Conversation

cakebaker
Copy link
Contributor

This PR adds -o/--once, though the functionality itself was already there. It's the same we currently use for when there is no argument specified.

@cakebaker
Copy link
Contributor Author

Changes since last push:

  • disabled tests using run_ucmd_as_root on Windows

@cakebaker
Copy link
Contributor Author

Changes since last push:

  • made the tests using run_ucmd_as_root linux-only

@cakebaker
Copy link
Contributor Author

Changes since last push:

  • fixed merge conflict

@cakebaker
Copy link
Contributor Author

Changes since last push:

  • made the *_as_non_root tests linux-only, too

@cakebaker
Copy link
Contributor Author

cakebaker commented Apr 19, 2024

The remaining clippy errors are fixed in #66 The clippy errors have been fixed in the meantime.

Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 46.77%. Comparing base (e2d7ed6) to head (2c68b9c).
Report is 11 commits behind head on main.

Current head 2c68b9c differs from pull request most recent head bcfc147

Please upload reports for the commit bcfc147 to get more accurate results.

Files Patch % Lines
src/uu/slabtop/src/slabtop.rs 4.34% 21 Missing and 1 partial ⚠️
tests/by-util/test_slabtop.rs 70.37% 4 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
- Coverage   51.30%   46.77%   -4.53%     
==========================================
  Files          18       18              
  Lines        2306     2313       +7     
  Branches      333      333              
==========================================
- Hits         1183     1082     -101     
+ Misses       1060     1051       -9     
- Partials       63      180     +117     
Flag Coverage Δ
macos_latest ?
ubuntu_latest 47.43% <40.00%> (+0.86%) ⬆️
windows_latest 0.10% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sylvestre sylvestre merged commit 8ecd780 into uutils:main Jul 3, 2024
13 checks passed
@cakebaker cakebaker deleted the slabtop_once branch July 3, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants