Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util.rs: fix "needless_borrow" errors #66

Closed
wants to merge 1 commit into from

Conversation

cakebaker
Copy link
Contributor

This PR fixes two "needless borrow" errors I introduced with #64

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 49.22%. Comparing base (933349e) to head (0a9d608).
Report is 3 commits behind head on main.

Files Patch % Lines
tests/common/util.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
+ Coverage   43.73%   49.22%   +5.48%     
==========================================
  Files          18       18              
  Lines        2140     2200      +60     
  Branches      300      311      +11     
==========================================
+ Hits          936     1083     +147     
- Misses       1044     1078      +34     
+ Partials      160       39     -121     
Flag Coverage Δ
macos_latest 48.65% <ø> (?)
ubuntu_latest 43.73% <ø> (ø)
windows_latest 0.11% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cakebaker cakebaker mentioned this pull request Apr 19, 2024
@cakebaker cakebaker requested a review from sylvestre May 1, 2024 09:25
@cakebaker
Copy link
Contributor Author

cakebaker commented May 9, 2024

Closing this PR, the issue got fixed in #70

@cakebaker cakebaker closed this May 9, 2024
@cakebaker cakebaker deleted the util_rs_fix_needless_borrow branch May 9, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant