Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WinOS: fixes nodename calculation #33

Merged
merged 2 commits into from
Jan 28, 2023
Merged

Conversation

rivy
Copy link
Member

@rivy rivy commented Jan 18, 2023

This adds tests and fixes the extraneous NUL character suffix for the WinOS nodename calculation.

Fixes #32.

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #33 (15a2a0f) into main (8d02b2a) will decrease coverage by 6.51%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
- Coverage   73.48%   66.98%   -6.51%     
==========================================
  Files           5        5              
  Lines         347      421      +74     
  Branches       67       72       +5     
==========================================
+ Hits          255      282      +27     
- Misses         37       85      +48     
+ Partials       55       54       -1     
Flag Coverage Δ
macos_latest 52.38% <100.00%> (-25.59%) ⬇️
ubuntu_latest 52.38% <100.00%> (-25.59%) ⬇️
windows_latest 64.96% <100.00%> (-6.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/windows.rs 73.22% <100.00%> (+0.65%) ⬆️
tests/integration_test.rs 100.00% <100.00%> (+10.52%) ⬆️
src/lib.rs 2.00% <0.00%> (-98.00%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rivy
Copy link
Member Author

rivy commented Jan 20, 2023

Odd; I don't understand why the code coverage for src/lib.rs took a nosedive.
It's still essentially only the platform-info API description (via trait definition).

@rivy
Copy link
Member Author

rivy commented Jan 28, 2023

@sylvestre , I'm going to merge this unless you have an objection.

I've made no changes that should have dropped the code coverage; I think it must be some coverage bug.

I do have a fully reworked version on my wip branch, but I need to revise the structure a bit and add some comments/documentation. I'll post a PR for that re-write when I get done (probably next week).

@sylvestre sylvestre merged commit d0eb0b5 into uutils:main Jan 28, 2023
@sylvestre
Copy link
Contributor

I am good, sorry :)

@rivy rivy deleted the fix.nodename branch February 12, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nodename() returns values with trailing NUL (for WinOS)
2 participants