Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodename() returns values with trailing NUL (for WinOS) #32

Closed
rivy opened this issue Jan 15, 2023 · 0 comments · Fixed by #33
Closed

nodename() returns values with trailing NUL (for WinOS) #32

rivy opened this issue Jan 15, 2023 · 0 comments · Fixed by #33

Comments

@rivy
Copy link
Member

rivy commented Jan 15, 2023

The return value of nodename() returns a value with an erroneous trailing NUL character for WinOS.

I have a fix and will post a PR for it.
rivy added a commit to rivy/rs.platform-info that referenced this issue Jan 15, 2023
@rivy
fix nodename string conversion (fixes uutils#32)
6b1d35e
rivy added a commit to rivy/rs.platform-info that referenced this issue Jan 18, 2023
@rivy
fix nodename string conversion (fixes uutils#32)
367a8c2
rivy added a commit to rivy/rs.platform-info that referenced this issue Jan 26, 2023
@rivy
fix nodename string conversion (fixes uutils#32)
15a2a0f
@rivy rivy mentioned this issue Jan 26, 2023
Merged
@cakebaker cakebaker mentioned this issue May 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WinOS: fixes nodename calculation rivy/rs.platform-info
1 participant
@rivy