-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cat: Handle all flags correctly #6034
Conversation
I'm thinking now that I was confused with |
31e8e3a
to
cd70d7d
Compare
Changes since last push:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit torn on the test_
prefix. It's good for consistency now, but I'm thinking we could remove the test_
prefix everywhere later. But it's really not important, just something I wanted to bring up at some point.
Should not be a blocker to merge this though.
@tertsdiepraam Yes, I agree, though in practice I'm unsure how you would approach it as you can't just remove the prefix. |
@BenWiederhake Thanks! |
I was about to create a new PR removing the prefix everywhere. So let me ask the blunt, but honest question: What is the disadvantage? |
The "disadvantage" is that you often have to adapt the new function name because something like |
This PR fixes several bugs:
cat
does-b
overrides-n
but not the other way around, just like GNUcat
does-u
flag, just like GNUcat
doesThis is work towards #5998. Note that this is the first time that
args_override_self
is correct.I'm surprised that we already passed the GNU tests before!