Allow repeated flags much more often #5998
Comments
|
If I recall correctly, we fixed all of this with the |
I didn't look much further into it yet. Now that I try out random other tools, it seems like you're right :D EDIT: Oh! $ ls | sort --sort=month --sort=numeric
sort: options '-Mn' are incompatible
[$? = 2]
$ ls | cargo run sort --sort=month --sort=numeric
CODE_OF_CONDUCT.md
COMMANDS.txt
… |
|
Nice find :) |
|
Ah, apparently I prevented auto-closing in the wrong way. Can someone re-open this issue? It'll be a long time until this issue can be closed. |
|
I don't think an issue like this is the right approach. The problems should be fixed, but we should open issues for the problems we find, not for the potential problems we might find if that makes sense. An issue like this tends to go stale, becomes out of date, etc. |
|
In principle I would usually agree with this argument, but given that 11 out of 12 tools that I looked at have at least one bug related to it, I'll continue using the above checklist. Hmm. Actually, I think that answers it: Let's just keep this issue closed, because I can use the checklist anyway. |
|
Yes, but usually different bugs right? I'd keep this open if the exact same issue was present in all utils. But yeah, feel free to keep using the checklist :) |
|
Maybe we should reopen this. I got confused with other functionality and you're right that this should be checked for more utils. |
If seems that there are many cases where we define self-conflicts, but GNU accepts repeated arguments. This is especially unnecessary for boolean flags. Let's fix that! This issue tracks progress for all utils.
chgrp: at least-vis brokenchmod: not considered yetchown: not considered yetchroot: not considered yetcomm: at least-1is brokencp: at least-ais handled correctlycsplit: at least-kis brokendate: at least--resolutionis broken: date: implement --resolution #6143 , rest is fixed by date: fix interaction of flags, fix issues around --set #6142du: at least-sis brokenecho: at least-nis brokenfmt: at least-cis broken, fixed by fmt: accept repeated arguments #6355fold: at least-bis brokenid: at least-uis brokeninstall: at least-bis brokenjoin: at least-zis brokenkill: at least-lis brokenln: not considered yetlogname: not considered yetls: not considered yetmkdir: not considered yetmkfifo: not considered yetmknod: not considered yetmktemp: not considered yetmore: not considered yetmv: not considered yetnice: not considered yetnl: not considered yetnohup: not considered yetnproc: not considered yetnumfmt: not considered yetod: not considered yetpaste: not considered yetpathchk: not considered yetpinky: not considered yetpr: not considered yetprintenv: not considered yetprintf: not considered yetptx: not considered yetpwd: not considered yetreadlink: not considered yetrealpath: not considered yetrm: not considered yetrmdir: not considered yetruncon: not considered yetseq: not considered yetshred: not considered yetsleep: not considered yetsort: at least--sort=month --sort=numericis brokensplit: not considered yetstat: not considered yetstdbuf: not considered yetstty: not considered yetsum: not considered yetsync: not considered yettac: not considered yettail: not considered yettee: not considered yettest: not considered yettimeout: not considered yettouch: not considered yettruncate: not considered yettsort: not considered yettty: not considered yetuname: not considered yetunexpand: not considered yetuniq: not considered yetunlink: not considered yetuptime: not considered yetusers: not considered yetvdir: not considered yetwc: not considered yetwho: not considered yetNot a problem (solved / not affected / works already)
arch: no repeatable optionsbase32: fully handled, see base32/base64/basenc: implement and test proper flag parsing #6007base64: fully handled, see base32/base64/basenc: implement and test proper flag parsing #6007basename: fully handled, see basename: Fix handling of repeated flags/arguments #6018basenc: fully handled, see base32/base64/basenc: implement and test proper flag parsing #6007cat: at least-uis broken, see cat: Handle all flags correctly #6034chcon: at least-vis broken, see chcon: Handle repeated flags and overrides between --no-XXX and --XXX #6039cksum: at least--base64is broken, see cksum: permit repeated flags, handle overrides correctly, implement base64 output #6041cut: works alreadydd: Seems to already work, not gonna touch it.df: works alreadydir: just defers tolsdircolors: at least-pis broken, see dircolors: accept repeated flags #6150dirname: at least-zis broken, see dirname: accept repeated flag #6151env: at least-iis broken, fixed by id: Handle repeated flags, recognize conflict between pretty-print and passwd file-entry #6288expand: works alreadyexpr: works completely differentlyfactor: already worksfalse: has no flags/argsgroups: has no flags/argshashsum: not a GNU toolhead: works alreadyhostid: has no flags/argshostname: works, BUT INCOMPLETE AND FRAGILElink: has no flags/argsshuf: fully handled, see shuf: include all echo args, not just the last #5978 and shuf: treat -e as a flag, not as a multi-value arg #5989tr: fully handled, see tr: Correctly handle multiple appearances of flag-args #6006true: has no flags/argswhoami: no repeatable optionsyes: no repeatable optionsThe text was updated successfully, but these errors were encountered: