Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Improve and speed up setup steps using github actions #4771

Merged

Conversation

Joining7943
Copy link
Contributor

@Joining7943 Joining7943 commented Apr 22, 2023

This pr speeds up installation of cargo tools in the ci by installing pre-built binaries with taiki-e/install-action where possible instead of building them from source with cargo install.

Setting up the rust toolchain with dtolnay/rust-toolchain simplifies and shortens the installation of the rust toolchain. This action is just used to outsource this setup step, so we don't have to care about it.

Some explicitly set environment variables which are already set by github actions are removed.

@Joining7943 Joining7943 force-pushed the ci-improve-setup-steps-use-github-actions branch 3 times, most recently from 3a4c9c6 to e83fbd8 Compare April 23, 2023 15:19
@Joining7943 Joining7943 marked this pull request as ready for review April 23, 2023 16:19
@Joining7943 Joining7943 force-pushed the ci-improve-setup-steps-use-github-actions branch from e83fbd8 to b5ea800 Compare April 23, 2023 16:20
@sylvestre sylvestre force-pushed the ci-improve-setup-steps-use-github-actions branch from b5ea800 to 4b243ba Compare May 15, 2023 08:48
@sylvestre
Copy link
Contributor

i didn't look everywhere but i see improvement on the coverage (Win: 25m => 17, mac 22 => 16)
well done :)

@sylvestre sylvestre merged commit 137fb4b into uutils:main May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants