-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
printf: move help strings to markdown file #4705
Conversation
src/uu/printf/printf.md
Outdated
The following escape sequences, organized here in alphabetical order, | ||
will print the corresponding character literal: | ||
|
||
\" double quote |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use a list here
src/uu/printf/printf.md
Outdated
|
||
WRITTEN BY : | ||
Nathan E. Ross, et al. for the uutils project | ||
|
||
MORE INFO : | ||
https://github.com/uutils/coreutils | ||
|
||
COPYRIGHT : | ||
Copyright 2015 uutils project. | ||
Licensed under the MIT License, please see LICENSE file for details |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove all that
src/uu/printf/printf.md
Outdated
Substitutions are used to pass additional argument(s) into the FORMAT string, to be formatted a | ||
particular way. E.g. | ||
|
||
printf 'the letter %X comes before the letter %X' 10 11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix the warnings
src/uu/printf/printf.md
Outdated
|
||
printf '%4.3i' 7 | ||
has a first parameter of 4 | ||
and a second parameter of 3 | ||
will result in ' 007' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use ``` for the example
src/uu/printf/src/printf.rs
Outdated
@@ -4,265 +4,14 @@ | |||
|
|||
use clap::{crate_version, Arg, ArgAction, Command}; | |||
use uucore::error::{UResult, UUsageError}; | |||
use uucore::format_usage; | |||
use uucore::{format_usage, help_about, help_usage, help_section}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please run rustfmt
in general, could you please use more * when it is list
thanks |
Co-authored-by: Sylvestre Ledru <[email protected]>
…m11o/coreutils-rs into printf-move-strings-to-md-files
GNU testsuite comparison:
|
src/uu/printf/printf.md
Outdated
will print | ||
'it is 22 F in Portland | ||
it is 25 F in Boston | ||
it is 27 F in Boston | ||
' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will print | |
'it is 22 F in Portland | |
it is 25 F in Boston | |
it is 27 F in Boston | |
' | |
will print | |
it is 22 F in Portland
it is 25 F in Boston
it is 27 F in Boston
src/uu/printf/printf.md
Outdated
``` | ||
|
||
will print | ||
'the letter A comes before the letter B' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please replace this by ```
Co-authored-by: Sylvestre Ledru <[email protected]>
Co-authored-by: Sylvestre Ledru <[email protected]>
Co-authored-by: Sylvestre Ledru <[email protected]>
Co-authored-by: Sylvestre Ledru <[email protected]>
Co-authored-by: Sylvestre Ledru <[email protected]>
Co-authored-by: Sylvestre Ledru <[email protected]>
Co-authored-by: Sylvestre Ledru <[email protected]>
Co-authored-by: Sylvestre Ledru <[email protected]>
Co-authored-by: Sylvestre Ledru <[email protected]>
Co-authored-by: Sylvestre Ledru <[email protected]>
Co-authored-by: Sylvestre Ledru <[email protected]>
Co-authored-by: Sylvestre Ledru <[email protected]>
…m11o/coreutils-rs into printf-move-strings-to-md-files
Thank you for your feedback.
I have confirmed the output we executed
I would like to clarify my intentions with the proposed changes:
I have a question regarding to the points you raised. In Markdown, to display an alert(BEL, I would be genuinely grateful for your guidance on which should be considered correct. Should we prioritize the Markdown format or the actual output of the Thanks. |
issue: #4368
printf --help
outputs the following.