Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move help strings to markdown files #4368

Closed
tertsdiepraam opened this issue Feb 14, 2023 · 11 comments
Closed

Move help strings to markdown files #4368

tertsdiepraam opened this issue Feb 14, 2023 · 11 comments
Labels

Comments

@tertsdiepraam
Copy link
Member

tertsdiepraam commented Feb 14, 2023

After #2816 and #3180, we can move all the help strings to markdown files.

Below is a list of utils that need to be converted. Let's see if GitHub's task lists are useful here. All of them should be considered good-first-issues.

If you want to pick one up, for now just create a PR and we'll update this list.

Note that some utils (like who) have platform-specific help texts. We should probably leave those until we have a good solution for that.

@zleyyij
Copy link
Contributor

zleyyij commented Feb 15, 2023

It doesn't appear to be possible to Convert to Issue with my permissions, I checked on multiple browsers and proved that it was working on a project where I have sufficient perms.

@tertsdiepraam
Copy link
Member Author

Oh I hoped that would be possible. That's too bad. I'll figure out some other way to track this. In the meantime you can just create a PR and I'll update the list manually.

@tertsdiepraam
Copy link
Member Author

We could just accept PRs that mention the utils they update and then we manually update, but that's not a great solution. Also, with a project like this, we get situations like this quite often, so I'd like to find a better solution. @sylvestre any ideas?

@cakebaker
Copy link
Contributor

What should be the order of the sections inside the markdown files? Currently half of the files use

Usage
About
...

and the other half:

About
Usage
...

@tertsdiepraam
Copy link
Member Author

Hmm good question. Both will work, but I think I prefer usage first, because that's also how it shows up in clap and in the online docs. Maybe we should even change the macro for the usage to parse the code block directly below the title, so you can write:

# numfmt
```
numfmt [OPTION]... [NUMBER]...
```

## About

Convert numbers from/to human-readable strings

Do you have a preference one way or the other?

@cakebaker
Copy link
Contributor

My preference would be the same as in the online docs:

# numfmt
```
numfmt [OPTION]... [NUMBER]...
```

Convert numbers from/to human-readable strings

@tertsdiepraam
Copy link
Member Author

Ah I see, that would require a separate macro for the about text I suppose. I like that it enforces a strict format. Do you want to implement that?

@cakebaker
Copy link
Contributor

Yes.

zleyyij pushed a commit to zleyyij/coreutils that referenced this issue Feb 15, 2023
@tertsdiepraam tertsdiepraam pinned this issue Feb 16, 2023
@sylvestre
Copy link
Contributor

Looks like we are good ?! :)
cc @tertsdiepraam

@tertsdiepraam
Copy link
Member Author

Wow, that's great! Thanks everyone!

@sylvestre
Copy link
Contributor

yeah, bravo :)

@cakebaker cakebaker unpinned this issue May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants