Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-4356: Add Code Linter To utopia-php/websocket #19

Merged
merged 12 commits into from
Jul 17, 2023

Conversation

Rutam21
Copy link
Contributor

@Rutam21 Rutam21 commented Oct 30, 2022

What

This PR aims to resolve the issue appwrite/appwrite#4356.

How

  • Code Linter has been added to utopia-php/websocket repository.
  • All existing files are formatted as per the Linting rules.
  • PR Template has been followed as mentioned in Feat: Implement linter ab#7.

Fixes appwrite/appwrite#4356

@Rutam21
Copy link
Contributor Author

Rutam21 commented Oct 30, 2022

@Meldiron Please review and suggest changes, if any. Thanks.

cc: @stnguyen90 @christyjacob4

@PineappleIOnic
Copy link
Member

Thank you so much for the PR 🤩. We're adding the hacktoberfest-accepted label to ensure this PR counts towards your Hacktoberfest contributions count. With that said, please stay active on this PR to address any comments once you receive a review. Happy Hacktoberfest! 🎃

Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! 🤯 Looks like there are merge conflicts now. Would you please fix the merge conflicts?

@christyjacob4
Copy link
Contributor

@Rutam21 thanks a lot for your contributions during Hacktoberfest 2022!

Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord. 

@christyjacob4 christyjacob4 dismissed stnguyen90’s stale review July 17, 2023 10:11

Comments addressed

@christyjacob4 christyjacob4 merged commit a58acff into utopia-php:main Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💄 Add Code Linter To ‘utopia-php/websocket’
4 participants