Feat: Implement linter #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 10, 2022
This was referenced Oct 30, 2022
This was referenced Jul 17, 2023
Meldiron
commented
Jul 17, 2023
christyjacob4
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements linter into the repository. This allows you to run
composer formatto auto-fix issues, andcomposer lintto check for errors. It now also auto-checks every PR withcomposer lintto create failed test if a code formatting is not correct.Lastly, this PR updates existing code to pass linter tests - to have proper code style.
Test Plan
Related PRs and Issues
No related issue.
Have you read the Contributing Guidelines on issues?
Yes! 👏