Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotation matrices not required to be orthonormal #41

Open
ben-congram opened this issue May 6, 2021 · 0 comments
Open

Rotation matrices not required to be orthonormal #41

ben-congram opened this issue May 6, 2021 · 0 comments

Comments

@ben-congram
Copy link

ben-congram commented May 6, 2021

  • The reproject function called in lgmath::se3::Transformation's constructor (and other spots) is conditioned on det(C) = 1 but this is not a sufficient check to determine if C is in SO(3)
  • Therefore, users could create a Transformation with C_ab_ = diag(2,0.5,1), for example
  • Even when constructed properly, round-off error can stack up in rare cases if matrix is never forcibly reprojected
  • May want to add check that C^T * C = 1, if computationally feasible
ben-congram added a commit to utiasASRL/vtr3 that referenced this issue May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant