Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SERVER_ORIGIN, WEB_ORIGIN, WEB_ORIGIN_BUILD etc の代わりに CORS_ALLOW_ORIGINS を使う #516

Merged
merged 5 commits into from
Nov 10, 2024

Conversation

aster-void
Copy link
Contributor

影響範囲

環境変数に影響がある。

動作要件

補足

レビューリクエストを出す前にチェック!

  • 改めてセルフレビューしたか
  • 手動での動作検証を行ったか
  • server の機能追加ならば、テストを書いたか
    • 理由: 書いた | server の機能追加ではない
  • 間違った使い方が存在するならば、それのドキュメントをコメントで書いたか
    • 理由: 書いた | 間違った使い方は存在しない
  • わかりやすいPRになっているか

WEB_ORIGIN=http://localhost:5173
MOBILE_ORIGIN=http://localhost:8081
# CORS allow origins, separated by "," | no space is allowed before/after ","
CORS_ALLOW_ORIGINS=http://localhost:3000,http://localhost:3001
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

今はフロントエンドの5173、バックエンドは3000にしてます、一応!

@aster-void aster-void merged commit a91c531 into main Nov 10, 2024
8 checks passed
@aster-void aster-void deleted the just-list-cors-allow branch November 10, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants