Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use object #474

Merged
merged 7 commits into from
Nov 11, 2024
Merged

use object #474

merged 7 commits into from
Nov 11, 2024

Conversation

aster-void
Copy link
Contributor

@aster-void aster-void commented Oct 10, 2024 •
edited
Loading

TODO:

create web/public/avatar-fallback.webp

PRの概要

具体的な変更内容

影響範囲

動作要件

補足

レビューリクエストを出す前にチェック！

  • 改めてセルフレビューしたか
  • 手動での動作検証を行ったか
  • server の機能追加ならば、テストを書いたか
    • 理由: 書いた | server の機能追加ではない
  • 間違った使い方が存在するならば、それのドキュメントをコメントで書いたか
    • 理由: 書いた | 間違った使い方は存在しない
  • わかりやすいPRになっているか

@aster-void aster-void marked this pull request as draft October 10, 2024 10:46
@aster-void aster-void marked this pull request as ready for review November 11, 2024 08:40
naka-12
naka-12 approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@naka-12 naka-12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aster-void aster-void merged commit 412b1ce into main Nov 11, 2024
8 checks passed
@aster-void aster-void deleted the use-object branch November 11, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naka-12 naka-12 naka-12 approved these changes

@KaichiManabe KaichiManabe Awaiting requested review from KaichiManabe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aster-void @naka-12