Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USWDS-Site - Changelog: Add styling to table headers [#5986] #2957

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −0
Draft

USWDS-Site - Changelog: Add styling to table headers [#5986] #2957

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions _data/changelogs/component-table.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,14 @@ type: component
changelogURL:

items:
- date: NNNN-NN-NN
summary: Updated the table component styles so that table headers get consistent styling.
summaryAdditional: Prior to this update styling only impacted table headers in the `<thead>` tag.
Comment on lines +7 to +9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion (non-blocking): We might want to reword to focus on the fix and match existing change log language

Not sure if this is better but here's an alternative:

Suggested change
- date: NNNN-NN-NN
summary: Updated the table component styles so that table headers get consistent styling.
summaryAdditional: Prior to this update styling only impacted table headers in the `<thead>` tag.
- date: NNNN-NN-NN
summary: Fixed a bug that prevented `th` elements outside of `thead` from acquiring table heading styles.
summaryAdditional: Now, table headings will have consistent styles anywhere in the table element.

Curious what others thing before accepting my recommendation!

isBreaking: false
affectsStyles: true
githubPr: 5986
githubRepo: uswds
versionUswds: N.N.N
- date: 2024-03-20
summary: Added WCAG compliance tag and accessibility test status section.
affectsGuidance: true
Expand Down