USWDS-Site - Changelog: Add styling to table headers [#5986] #2957
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cathybaptista
requested review from
mahoneycm,
amyleadem,
mlloydbixal and
RachelCorsino
This was referenced Nov 7, 2024
mahoneycm
reviewed
Nov 13, 2024
Comment on lines
+7
to
+9
| - date: NNNN-NN-NN | ||
| summary: Updated the table component styles so that table headers get consistent styling. | ||
| summaryAdditional: Prior to this update styling only impacted table headers in the `<thead>` tag. |
There was a problem hiding this comment.
Suggestion (non-blocking): We might want to reword to focus on the fix and match existing change log language
Not sure if this is better but here's an alternative:
Suggested change
| - date: NNNN-NN-NN | |
| summary: Updated the table component styles so that table headers get consistent styling. | |
| summaryAdditional: Prior to this update styling only impacted table headers in the `<thead>` tag. | |
| - date: NNNN-NN-NN | |
| summary: Fixed a bug that prevented `th` elements outside of `thead` from acquiring table heading styles. | |
| summaryAdditional: Now, table headings will have consistent styles anywhere in the table element. |
Curious what others thing before accepting my recommendation!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changelog for uswds/uswds#5986
Related PR
uswds/uswds#5986
Preview link
Table component changelog →