Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests for schema support of date-time datatypes #233

Merged
merged 5 commits into from
Sep 27, 2022
Merged

Unit tests for schema support of date-time datatypes #233

merged 5 commits into from
Sep 27, 2022

Conversation

wendellpiez
Copy link
Collaborator

@wendellpiez wendellpiez commented Aug 29, 2022 •
edited
Loading

Committer Notes

This separates out and adds schema validation unit tests related to dateTime datatypes date-time and date-time-no-time-zone picking up #231. Behind that issue are #224 and #229.

To do:

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

@david-waltermire david-waltermire linked an issue Sep 1, 2022 that may be closed by this pull request
Unit test dateTime datatypes after update #231
Closed
3 tasks
@david-waltermire david-waltermire marked this pull request as ready for review September 22, 2022 18:17
@david-waltermire
Copy link
Collaborator

david-waltermire commented Sep 23, 2022 •
edited
Loading

Some of the unit tests have commented out XML, without an explanation why. This content should either be 1) deleted if it is not needed for the test or 2) properly commented to reflect why it is commented out.

@wendellpiez Would you please do this cleanup before we merge?

david-waltermire
david-waltermire suggested changes Sep 23, 2022
View reviewed changes
Copy link
Collaborator

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment cleanup needed.

@wendellpiez wendellpiez self-assigned this Sep 23, 2022
david-waltermire
david-waltermire approved these changes Sep 27, 2022
View reviewed changes
Copy link
Collaborator

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@david-waltermire david-waltermire merged commit c7b3733 into usnistgov:develop Sep 27, 2022
david-waltermire added a commit that referenced this pull request Dec 7, 2022
@wendellpiez @david-waltermire
Unit tests for schema support of date-time datatypes (#233)
416ece8 
* Cleanup; separating datetime-related testing
* Adding some basic testing of date-time values per #231 (more to come)
* Adding tests from Issue #224
* Removed extraneous comments

Co-authored-by: David Waltermire <[email protected]>
aj-stein-nist pushed a commit to aj-stein-nist/metaschema that referenced this pull request Jan 9, 2023
@wendellpiez @david-waltermire @aj-stein-nist
Unit tests for schema support of date-time datatypes (usnistgov#233)
8c26691 
* Cleanup; separating datetime-related testing
* Adding some basic testing of date-time values per usnistgov#231 (more to come)
* Adding tests from Issue usnistgov#224
* Removed extraneous comments

Co-authored-by: David Waltermire <[email protected]>
aj-stein-nist pushed a commit to aj-stein-nist/metaschema that referenced this pull request Jan 10, 2023
@wendellpiez @david-waltermire @aj-stein-nist
Unit tests for schema support of date-time datatypes (usnistgov#233)
db28ae1 
* Cleanup; separating datetime-related testing
* Adding some basic testing of date-time values per usnistgov#231 (more to come)
* Adding tests from Issue usnistgov#224
* Removed extraneous comments

Co-authored-by: David Waltermire <[email protected]>
aj-stein-nist pushed a commit to aj-stein-nist/metaschema that referenced this pull request Jan 10, 2023
@wendellpiez @david-waltermire @aj-stein-nist
Unit tests for schema support of date-time datatypes (usnistgov#233)
8bc3bf3 
* Cleanup; separating datetime-related testing
* Adding some basic testing of date-time values per usnistgov#231 (more to come)
* Adding tests from Issue usnistgov#224
* Removed extraneous comments

Co-authored-by: David Waltermire <[email protected]>
aj-stein-nist pushed a commit to aj-stein-nist/metaschema that referenced this pull request Jan 10, 2023
@wendellpiez @david-waltermire @aj-stein-nist
Unit tests for schema support of date-time datatypes (usnistgov#233)
dd49be6 
* Cleanup; separating datetime-related testing
* Adding some basic testing of date-time values per usnistgov#231 (more to come)
* Adding tests from Issue usnistgov#224
* Removed extraneous comments

Co-authored-by: David Waltermire <[email protected]>
aj-stein-nist pushed a commit to aj-stein-nist/metaschema that referenced this pull request Jan 10, 2023
@wendellpiez @david-waltermire @aj-stein-nist
Unit tests for schema support of date-time datatypes (usnistgov#233)
a1228ec 
* Cleanup; separating datetime-related testing
* Adding some basic testing of date-time values per usnistgov#231 (more to come)
* Adding tests from Issue usnistgov#224
* Removed extraneous comments

Co-authored-by: David Waltermire <[email protected]>
aj-stein-nist pushed a commit to aj-stein-nist/metaschema that referenced this pull request Jan 10, 2023
@wendellpiez @david-waltermire @aj-stein-nist
Unit tests for schema support of date-time datatypes (usnistgov#233)
c87cc52 
* Cleanup; separating datetime-related testing
* Adding some basic testing of date-time values per usnistgov#231 (more to come)
* Adding tests from Issue usnistgov#224
* Removed extraneous comments

Co-authored-by: David Waltermire <[email protected]>
david-waltermire added a commit that referenced this pull request Mar 9, 2023
@wendellpiez @david-waltermire
Unit tests for schema support of date-time datatypes (#233)
9c32d41 
* Cleanup; separating datetime-related testing
* Adding some basic testing of date-time values per #231 (more to come)
* Adding tests from Issue #224
* Removed extraneous comments

Co-authored-by: David Waltermire <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-waltermire david-waltermire david-waltermire approved these changes

Assignees

@wendellpiez wendellpiez

Labels
None yet
Projects
NIST OSCAL Work Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unit test dateTime datatypes after update
2 participants
@wendellpiez @david-waltermire