Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test dateTime datatypes after update #231

Closed
3 tasks
wendellpiez opened this issue Aug 24, 2022 · 1 comment · Fixed by #233
Closed
3 tasks

Unit test dateTime datatypes after update #231

wendellpiez opened this issue Aug 24, 2022 · 1 comment · Fixed by #233
Assignees
Labels
enhancement New feature or request

Comments

@wendellpiez
Copy link
Collaborator

User Story:

Following correction to regular expressions made in #224 let's unit test the dateTime datatypes (with and without time zones) in Metaschema unit testing.

That Issue gives links to examples of passing and failing values to use. Testing should expose edge cases as well as normal cases.

Goals:

Unit test the latest regular expressions (JSON and XSD) for date- and time-related datatypes.

Continue to build out the capabilities of Metaschema unit testing (of validity and functionality of generated schemas).

Dependencies:

#224

Acceptance Criteria

  • All website and readme documentation affected by the changes in this issue have been updated. Changes to the website can be made in the docs/content directory of your branch.
  • A Pull Request (PR) is submitted that fully addresses the goals of this User Story. This issue is referenced in the PR.
  • The CI-CD build process runs without any reported errors on the PR. This can be confirmed by reviewing that all checks have passed in the PR.

{The items above are general acceptance criteria for all User Stories. Please describe anything else that must be completed for this issue to be considered resolved.}

@wendellpiez wendellpiez added the enhancement New feature or request label Aug 24, 2022
@wendellpiez wendellpiez changed the title Unit test dataTime datatypes after update Unit test dateTime datatypes after update Aug 24, 2022
@david-waltermire david-waltermire added this to the Metaschema 0.9.0 milestone Aug 24, 2022
@wendellpiez
Copy link
Collaborator Author

There is WIP that addresses this issue in part, waiting behind a parked Issue (#186), in a working branch:

https://github.com/wendellpiez/metaschema/tree/feature-metaschema-relocation-plus-enhancementsA

It appears to be in conflict with develop: wendellpiez/metaschema@develop...feature-metaschema-relocation-plus-enhancementsA

@david-waltermire-nist any chance you could take a look?

@wendellpiez wendellpiez moved this from Todo to In Progress in NIST OSCAL Work Board Aug 26, 2022
wendellpiez added a commit to wendellpiez/metaschema that referenced this issue Aug 29, 2022
@david-waltermire david-waltermire linked a pull request Sep 1, 2022 that will close this issue
7 tasks
@david-waltermire david-waltermire moved this from In Progress to Under Review in NIST OSCAL Work Board Sep 1, 2022
@david-waltermire david-waltermire moved this from Under Review to In Progress in NIST OSCAL Work Board Sep 26, 2022
david-waltermire added a commit that referenced this issue Sep 27, 2022
* Cleanup; separating datetime-related testing
* Adding some basic testing of date-time values per #231 (more to come)
* Adding tests from Issue #224
* Removed extraneous comments

Co-authored-by: David Waltermire <[email protected]>
Repository owner moved this from In Progress to Done in NIST OSCAL Work Board Sep 27, 2022
david-waltermire added a commit that referenced this issue Dec 7, 2022
* Cleanup; separating datetime-related testing
* Adding some basic testing of date-time values per #231 (more to come)
* Adding tests from Issue #224
* Removed extraneous comments

Co-authored-by: David Waltermire <[email protected]>
aj-stein-nist pushed a commit to aj-stein-nist/metaschema that referenced this issue Jan 9, 2023
* Cleanup; separating datetime-related testing
* Adding some basic testing of date-time values per usnistgov#231 (more to come)
* Adding tests from Issue usnistgov#224
* Removed extraneous comments

Co-authored-by: David Waltermire <[email protected]>
aj-stein-nist pushed a commit to aj-stein-nist/metaschema that referenced this issue Jan 10, 2023
* Cleanup; separating datetime-related testing
* Adding some basic testing of date-time values per usnistgov#231 (more to come)
* Adding tests from Issue usnistgov#224
* Removed extraneous comments

Co-authored-by: David Waltermire <[email protected]>
aj-stein-nist pushed a commit to aj-stein-nist/metaschema that referenced this issue Jan 10, 2023
* Cleanup; separating datetime-related testing
* Adding some basic testing of date-time values per usnistgov#231 (more to come)
* Adding tests from Issue usnistgov#224
* Removed extraneous comments

Co-authored-by: David Waltermire <[email protected]>
aj-stein-nist pushed a commit to aj-stein-nist/metaschema that referenced this issue Jan 10, 2023
* Cleanup; separating datetime-related testing
* Adding some basic testing of date-time values per usnistgov#231 (more to come)
* Adding tests from Issue usnistgov#224
* Removed extraneous comments

Co-authored-by: David Waltermire <[email protected]>
aj-stein-nist pushed a commit to aj-stein-nist/metaschema that referenced this issue Jan 10, 2023
* Cleanup; separating datetime-related testing
* Adding some basic testing of date-time values per usnistgov#231 (more to come)
* Adding tests from Issue usnistgov#224
* Removed extraneous comments

Co-authored-by: David Waltermire <[email protected]>
aj-stein-nist pushed a commit to aj-stein-nist/metaschema that referenced this issue Jan 10, 2023
* Cleanup; separating datetime-related testing
* Adding some basic testing of date-time values per usnistgov#231 (more to come)
* Adding tests from Issue usnistgov#224
* Removed extraneous comments

Co-authored-by: David Waltermire <[email protected]>
david-waltermire added a commit that referenced this issue Mar 9, 2023
* Cleanup; separating datetime-related testing
* Adding some basic testing of date-time values per #231 (more to come)
* Adding tests from Issue #224
* Removed extraneous comments

Co-authored-by: David Waltermire <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants