Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metaschema-java v0.11.0 update #150

Merged
merged 6 commits into from
Jul 5, 2023
Merged

metaschema-java v0.11.0 update #150

merged 6 commits into from
Jul 5, 2023

Conversation

david-waltermire
Copy link
Collaborator

@david-waltermire david-waltermire commented Jun 26, 2023 •
edited
Loading

Committer Notes

  • A few adjustments for modifications made in the metaschema-java API and OSCAL model changes.
  • Updating version to 1.0.5.0.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website and readme documentation affected by the changes you made?

@david-waltermire
Copy link
Collaborator Author

This PR won't build properly until the following OSCAL PRs are merged and the oscal submodule is updated.

@david-waltermire david-waltermire marked this pull request as ready for review June 29, 2023 21:36
@david-waltermire
Copy link
Collaborator Author

Confirmed this PR addresses #13.

This was linked to issues Jul 3, 2023
Oscal-cli -Validastion is throwing an error oscal-cli version 0.3.4-SNAPSHOT #141
Closed
Invalid handling of markdown text with nested style when saving to XML #5
Closed
Incorrect serialization of list items in XML #13
Closed
@aj-stein-nist aj-stein-nist changed the title metaschema-java v0.9.0 update metaschema-java v0.11.0 update Jul 3, 2023
@david-waltermire
Copy link
Collaborator Author

@aj-stein-nist Would you please mark #18 as resolved by this PR?

@david-waltermire david-waltermire mentioned this pull request Jul 3, 2023
Closed
@david-waltermire
Copy link
Collaborator Author

Added unit test for #13.

@david-waltermire david-waltermire mentioned this pull request Jul 4, 2023
Closed
@david-waltermire
Copy link
Collaborator Author

@aj-stein-nist Would you please mark #3 as resolved too. I confirmed this is working using a manual round-trip using oscal-cli.

@aj-stein-nist aj-stein-nist linked an issue Jul 5, 2023 that may be closed by this pull request
XSLT output differs from Saxon #18
Closed
@aj-stein-nist
Copy link
Collaborator

@aj-stein-nist Would you please mark #18 as resolved by this PR?

Done.

@aj-stein-nist aj-stein-nist linked an issue Jul 5, 2023 that may be closed by this pull request
Import/Export loop of NIST_SP-800-53_rev5_catalog.xml produces a different XML than the original #3
Closed
@aj-stein-nist
Copy link
Collaborator

@aj-stein-nist Would you please mark #3 as resolved too. I confirmed this is working using a manual round-trip using oscal-cli.

Done.

aj-stein-nist
aj-stein-nist approved these changes Jul 5, 2023
View reviewed changes
src/test/java/gov/nist/secauto/oscal/java/OscalBindingContextTest.java
}

@Test
void testLoadCatalogTightLists() throws IOException, URISyntaxException {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, non-blocking: I like the regression tests!

@aj-stein-nist aj-stein-nist merged commit 4cd4a8b into usnistgov:develop Jul 5, 2023
aj-stein-nist added a commit that referenced this pull request Jul 6, 2023
@aj-stein-nist
Bump major version after #150 merged
688ab8b 
There have been a few module changes, specifically around profile resolution
in this release, that will be breaking backwards compatibility for any downstream
tools relying on identical import behavior. Therefore, we will bump up the version
numbers to follow semantic versioning requirements.
@david-waltermire david-waltermire deleted the update-to-metaschema-java-0.9.0 branch September 27, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aj-stein-nist aj-stein-nist aj-stein-nist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@david-waltermire @aj-stein-nist