-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Updated Character Groups for XML Schema Regexes for OSCAL Token Data Type #1161
Test Updated Character Groups for XML Schema Regexes for OSCAL Token Data Type #1161
Conversation
Also @david-waltermire-nist, since this is a bug fix, not sure where you want to point this branch either. |
931012a
to
dc22670
Compare
Updated this to point to |
@david-waltermire-nist Will integrate the data type changes from usnistgov/metaschema#191 to complete this PR. |
@david-waltermire-nist, I know you are doing PR review, I assume this one is waaaay out of date. I can bring it up to the current commit if you need or we can close. Either way. |
Per conversation with PR, don't close this. Update to latest metaschema commit once usnistgov/metaschema#199 and usnistgov/metaschema#204. |
@mpemy, if you want I can update this PR accordingly (I agreed to that for the team before I depart today in #1161 (comment)) and you can clone my fork of the repo to test? It will be merged into |
0f0de01
to
0e18338
Compare
@david-waltermire-nist I know this is a small lift, but I pointed the submodule as metaschema changes have stabilized as it pertains to the OSCAL v1.0.3 release at least up to commit UPDATE: Haha, just kidding, I meant usnistgov/metaschema@42db043 on |
4fbba60
to
7ba4716
Compare
@david-waltermire-nist ok, haha, just kidding for a second time! Per our convo rebased to metaschema |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason this shouldn't be updated to commit 86952d7b283c41dcfcfcd68ceb7b7e1e2e289c9b?
7ba4716
to
24ab0f8
Compare
Nope, other then some really PEBKAC nonsense from me apologies. Please see updated force push. 🤦 |
Test updates in usnistgov/metaschema#183. This closes #1127.
Committer Notes
{Please provide a brief description of what this PR accomplishes. Be sure to reference any issues addressed. If the PR is a work-in-progress submitted for early review, please include [WIP] at the beginning of the title or mark the PR as DRAFT.}
All Submissions:
Changes to Core Features: