Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patching Metaschema (XSLT M4 implementation) datatypes with new definitions #1186

Closed
3 tasks
wendellpiez opened this issue Mar 17, 2022 · 4 comments · Fixed by #1161
Closed
3 tasks

Patching Metaschema (XSLT M4 implementation) datatypes with new definitions #1186

wendellpiez opened this issue Mar 17, 2022 · 4 comments · Fixed by #1161
Assignees
Labels
enhancement Scope: Metaschema Issues targeted at the metaschema pipeline User Story
Milestone

Comments

@wendellpiez
Copy link
Contributor

User Story:

Datatype support in the XSLT M4 Metaschema implementation needs to be updated to conform to latest work, so that XML and JSON schemas for OSCAL can take advantage of new definitions.

The work is being tracked in usnistgov/metaschema#191. New datatype definitions there must be integrated into the M4 pipeline.

This will also help address issues #1127, #1132, and #1105.

This Issue addresses changes supporting OSCAL 1.0.3, not a more thorough refactoring for 1.1.

Goals:

Capture new improved work on datatype definitions in schema generation from XSLT M4.

Dependencies:

New datatype definitions must be stable.

Acceptance Criteria

Note: the PR for this work will be in the usnistgov/metaschema repository.

  • All OSCAL website and readme documentation affected by the changes in this issue have been updated. Changes to the OSCAL website can be made in the docs/content directory of your branch.
  • A Pull Request (PR) is submitted that fully addresses the goals of this User Story. This issue is referenced in the PR.
  • The CI-CD build process runs without any reported errors on the PR. This can be confirmed by reviewing that all checks have passed in the PR.
@wendellpiez wendellpiez added this to the OSCAL 1.0.3 milestone Mar 17, 2022
@wendellpiez wendellpiez added the Scope: Metaschema Issues targeted at the metaschema pipeline label Mar 17, 2022
@wendellpiez wendellpiez self-assigned this Mar 17, 2022
@wendellpiez
Copy link
Contributor Author

As advised by @david-waltermire-nist , work proceeds in WIP branch: usnistgov/metaschema@develop...wendellpiez:issue181-tokendatatype

JSON Schema and XSD look good so far.

@wendellpiez
Copy link
Contributor Author

wendellpiez commented Mar 23, 2022

For alignment (from usnistgov/metaschema#191) the following new names are supported:

  • nonNegativeInteger -> non-negative-integer
  • positiveInteger -> positive-integer
  • dateTime -> date-time
  • base64Binary -> base64
  • dateTime-with-timezone -> date-time-with-timezone
  • email -> email-address

See most recent commit usnistgov/metaschema@26a66e9

@wendellpiez
Copy link
Contributor Author

wendellpiez commented Mar 23, 2022

@david-waltermire-nist let's review, as I think this work might be ready for integrating. Certainly worth looking at.

PR is here: usnistgov/metaschema#183

@david-waltermire
Copy link
Contributor

PR #1161 needs to be merged to complete this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Scope: Metaschema Issues targeted at the metaschema pipeline User Story
Projects
None yet
3 participants