Consistency with Boolean fields or empty assemblies in OSCAL models

[wendellpiez]

Describe the bug

In the assessment-common metaschema, there are definitions for two assemblies include-all, one in control-objective-selection and one in assessment-subject. (These might be consolidated.) They are empty assemblies - no contents are permitted.

In the profile model, in contrast, there is the semantically similar (identical) element all, except this is a Boolean value.

So we have (SSP):

<assessment-subject uuid="...">
  <include-all/>
 ...
 </assessment-subject>

or

'assessment-subject': {
  'include-all': {}
}

Profile:

<import href="...">
  <include>
    <all>true</all>
  </include>
</import>

'import': {
  'href': '...',
  'include': {
    'all': true }
  }
}

These should be consistent since there is no difference in meaning between the two forms.

Who is the bug affecting?

Users who wish to learn one way to do it.

Expected behavior (i.e. solution)

If not make these both fields with Boolean values, then make them empty assemblies.

See: oscal_profile_metaschema.xml line 219, oscal_assessment-common_metaschema.xml lines 449, 499.

Other Comments

Our original model for the profile had the empty-element form, but we changed it to the Boolean form to match with developers' expectations (or our expectations of their expectations).

[wendellpiez]

BTW this is a breaking change in data instances.