Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling controls by match pattern and ID, both together. #525

Closed
3 tasks
wendellpiez opened this issue Nov 1, 2019 · 3 comments · Fixed by #882
Closed
3 tasks

Calling controls by match pattern and ID, both together. #525

wendellpiez opened this issue Nov 1, 2019 · 3 comments · Fixed by #882
Assignees
Labels
Discussion Needed This issues needs to be reviewed by the OSCAL development team. enhancement model-refactor Used to mark issues related to model refactoring for the Metaschema v4 transition. Scope: Modeling Issues targeted at development of OSCAL formats User Story

Comments

@wendellpiez
Copy link
Contributor

User Story:

Due to schema limitations, currently it is not possible to combine, in a single profile, calls on controls by their IDs, with calls to controls based on ID matching.

For example this is not valid to the profile model:

<import href="catalog.xml">
  <include>
    <call control-id="ac-1"/>
    <match pattern="at.*"/>
  </include>
</import>

Goals:

Make it possible to use both selection by (literal) ID, along with selection by matching, calling a single catalog in a profile.

This could be permitted via parallel imports; permitting more than one include to appear in an import statement, or relaxing the model of include.

Dependencies:

Stable demonstration and testing of profile functionality (#508).

Acceptance Criteria

  • All OSCAL website and readme documentation affected by the changes in this issue have been updated. Changes to the OSCAL website can be made in the docs/content directory of your branch.
  • A Pull Request (PR) is submitted that fully addresses the goals of this User Story. This issue is referenced in the PR.
  • The CI-CD build process runs without any reported errors on the PR. This can be confirmed by reviewing that all checks have passed in the PR.

{The items above are general acceptance criteria for all User Stories. Please describe anything else that must be completed for this issue to be considered resolved.}

@david-waltermire david-waltermire added the Scope: Modeling Issues targeted at development of OSCAL formats label Jan 9, 2020
@david-waltermire david-waltermire added the model-refactor Used to mark issues related to model refactoring for the Metaschema v4 transition. label Sep 11, 2020
@david-waltermire david-waltermire added the Discussion Needed This issues needs to be reviewed by the OSCAL development team. label Mar 15, 2021
@david-waltermire
Copy link
Contributor

@wendellpiez I'd like to discuss this with you in regards to any changes that might need to be made in RC2 to make this possible now or in the future. We need to consider making sure this change will not break backwards compatibility.

@wendellpiez
Copy link
Contributor Author

@david-waltermire-nist agreed. Allowing include to have call*, match* instead of (call* | match*), for example, would be backward compatible as well as forward-compatible with an eventual (call|match)* model.

@david-waltermire
Copy link
Contributor

This was slated for 1.1, but is going to be made possible based on the refactoring from #845. This means we can address this in RC2.

@david-waltermire david-waltermire linked a pull request Apr 1, 2021 that will close this issue
13 tasks
wendellpiez added a commit to wendellpiez/OSCAL that referenced this issue Apr 6, 2021
wendellpiez added a commit to wendellpiez/OSCAL that referenced this issue Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Needed This issues needs to be reviewed by the OSCAL development team. enhancement model-refactor Used to mark issues related to model refactoring for the Metaschema v4 transition. Scope: Modeling Issues targeted at development of OSCAL formats User Story
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants