Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow overriding an existing Metaschema defintion #475

Closed
3 tasks
david-waltermire opened this issue Aug 22, 2019 · 2 comments
Closed
3 tasks

Disallow overriding an existing Metaschema defintion #475

david-waltermire opened this issue Aug 22, 2019 · 2 comments
Labels
enhancement User Story
Milestone
OSCAL 1.0 Milesto...

Comments

@david-waltermire
Copy link
Contributor

User Story:

As an OSCAL model developer, I need assurances that a model element I define is not overridden or replaced by another model element defined in an including Metaschema. This means that a define-assembly, define-field, or define-flag must not have a name conflict with another define-assembly, define-field, or define-flag in the same or imported Metaschema. This can be called "shadowing".

Goals:

  • Add a metaschema-check.sch rule for define-assembly, define-field, and define-flag to disallow a name to shadow another name.
  • Fix any OSCAL model cases where this might be happening.

Dependencies:

None.

Acceptance Criteria

  • All OSCAL website and readme documentation affected by the changes in this issue have been updated. Changes to the OSCAL website can be made in the docs/content directory of your branch.
  • A Pull Request (PR) is submitted that fully addresses the goals of this User Story. This issue is referenced in the PR.
  • The CI-CD build process runs without any reported errors on the PR. This can be confirmed by reviewing that all checks have passed in the PR.

{The items above are general acceptance criteria for all User Stories. Please describe anything else that must be completed for this issue to be considered resolved.}
@david-waltermire david-waltermire mentioned this issue Aug 22, 2019
Closed
4 tasks
wendellpiez added a commit to wendellpiez/OSCAL that referenced this issue Aug 23, 2019
@wendellpiez
Schematron now reports duplicate definitions in a Metaschema as an er…
93dd3f9 
…ror: see usnistgov#465, usnistgov#475
@wendellpiez wendellpiez mentioned this issue Aug 23, 2019
Merged
8 tasks
david-waltermire pushed a commit to david-waltermire/OSCAL that referenced this issue Aug 26, 2019
@wendellpiez @david-waltermire
Schematron now reports duplicate definitions in a Metaschema as an er…
d80479c 
…ror: see usnistgov#465, usnistgov#475
david-waltermire pushed a commit to david-waltermire/OSCAL that referenced this issue Aug 26, 2019
@wendellpiez @david-waltermire
Schematron now reports duplicate definitions in a Metaschema as an er…
23bc875 
…ror: see usnistgov#465, usnistgov#475
@wendellpiez
Copy link
Contributor

Schematron checking of Metaschema instances is now tighter, reporting clashing definitions. Ready to test. The change is included in PR #476.

david-waltermire pushed a commit that referenced this issue Aug 27, 2019
@wendellpiez @david-waltermire
Cleanup of models and data (#476)
0153500 
* Schematron now reports duplicate definitions in a Metaschema as an error: see #465, #475

* Catalog metaschema and SP800-53 catalog adjustments renaming 'subcontrol' to 'control' per Issue #473

* Refactored metaschemas to avoid definition clashes; more/better Schematron to detect such clashes

* Adding new module now required by catalog and profile metaschemas

* Revising profiles to be valid to newly revised schema (no more references to subcontrol elements only controls)

* Bug fix in Metaschema Schematron

* Delete FedRAMP_HIGH-baseline_profile.xml

* Delete FedRAMP_LOW-baseline_profile.xml

* Delete FedRAMP_MODERATE-baseline_profile.xml

* Create temp.txt

* Revised FedRAMP Profiles

These files include revisions to the FedRAMP baselines, plus a small FedRAMP catalog that provides three subcontrols added by FedRAMP.

* Delete temp.txt

* moved updated fedramp content to correct location

* New and improved FedRAMP profiles

* Repaired broken markdown conversion; added missing title content to FedRAMP catalog

* add note about b -> strong and i -> em (#9)

* Changed inline markup in FedRAMP profiles for lossless conversion

* One more adjustment in Markdown->XML conversion (images)

* One more time (cleaning up cleanup)
@david-waltermire
Copy link
Contributor Author

The PR for this has been merged. Closing.

bradh pushed a commit to bradh/OSCAL that referenced this issue Dec 4, 2019
@wendellpiez @bradh
Cleanup of models and data (usnistgov#476)
6099ce5 
* Schematron now reports duplicate definitions in a Metaschema as an error: see usnistgov#465, usnistgov#475

* Catalog metaschema and SP800-53 catalog adjustments renaming 'subcontrol' to 'control' per Issue usnistgov#473

* Refactored metaschemas to avoid definition clashes; more/better Schematron to detect such clashes

* Adding new module now required by catalog and profile metaschemas

* Revising profiles to be valid to newly revised schema (no more references to subcontrol elements only controls)

* Bug fix in Metaschema Schematron

* Delete FedRAMP_HIGH-baseline_profile.xml

* Delete FedRAMP_LOW-baseline_profile.xml

* Delete FedRAMP_MODERATE-baseline_profile.xml

* Create temp.txt

* Revised FedRAMP Profiles

These files include revisions to the FedRAMP baselines, plus a small FedRAMP catalog that provides three subcontrols added by FedRAMP.

* Delete temp.txt

* moved updated fedramp content to correct location

* New and improved FedRAMP profiles

* Repaired broken markdown conversion; added missing title content to FedRAMP catalog

* add note about b -> strong and i -> em (usnistgov#9)

* Changed inline markup in FedRAMP profiles for lossless conversion

* One more adjustment in Markdown->XML conversion (images)

* One more time (cleaning up cleanup)
aj-stein-nist pushed a commit to aj-stein-nist/OSCAL-forked that referenced this issue Jan 25, 2023
@wendellpiez @david-waltermire
Cleanup of models and data (usnistgov#476)
6497556 
* Schematron now reports duplicate definitions in a Metaschema as an error: see usnistgov#465, usnistgov#475

* Catalog metaschema and SP800-53 catalog adjustments renaming 'subcontrol' to 'control' per Issue usnistgov#473

* Refactored metaschemas to avoid definition clashes; more/better Schematron to detect such clashes

* Adding new module now required by catalog and profile metaschemas

* Revising profiles to be valid to newly revised schema (no more references to subcontrol elements only controls)

* Bug fix in Metaschema Schematron

* Delete FedRAMP_HIGH-baseline_profile.xml

* Delete FedRAMP_LOW-baseline_profile.xml

* Delete FedRAMP_MODERATE-baseline_profile.xml

* Create temp.txt

* Revised FedRAMP Profiles

These files include revisions to the FedRAMP baselines, plus a small FedRAMP catalog that provides three subcontrols added by FedRAMP.

* Delete temp.txt

* moved updated fedramp content to correct location

* New and improved FedRAMP profiles

* Repaired broken markdown conversion; added missing title content to FedRAMP catalog

* add note about b -> strong and i -> em (#9)

* Changed inline markup in FedRAMP profiles for lossless conversion

* One more adjustment in Markdown->XML conversion (images)

* One more time (cleaning up cleanup)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement User Story
Projects
None yet
Milestone
OSCAL 1.0 Milestone 2
Development

No branches or pull requests
2 participants
@wendellpiez @david-waltermire