-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syntax Modification: control/subcontrol #473
Comments
…rol' to 'control' per Issue usnistgov#473
…rol' to 'control' per Issue usnistgov#473
…rol' to 'control' per Issue usnistgov#473
* Schematron now reports duplicate definitions in a Metaschema as an error: see #465, #475 * Catalog metaschema and SP800-53 catalog adjustments renaming 'subcontrol' to 'control' per Issue #473 * Refactored metaschemas to avoid definition clashes; more/better Schematron to detect such clashes * Adding new module now required by catalog and profile metaschemas * Revising profiles to be valid to newly revised schema (no more references to subcontrol elements only controls) * Bug fix in Metaschema Schematron * Delete FedRAMP_HIGH-baseline_profile.xml * Delete FedRAMP_LOW-baseline_profile.xml * Delete FedRAMP_MODERATE-baseline_profile.xml * Create temp.txt * Revised FedRAMP Profiles These files include revisions to the FedRAMP baselines, plus a small FedRAMP catalog that provides three subcontrols added by FedRAMP. * Delete temp.txt * moved updated fedramp content to correct location * New and improved FedRAMP profiles * Repaired broken markdown conversion; added missing title content to FedRAMP catalog * add note about b -> strong and i -> em (#9) * Changed inline markup in FedRAMP profiles for lossless conversion * One more adjustment in Markdown->XML conversion (images) * One more time (cleaning up cleanup)
The model changes have been merged in PR #476. The documentation changes remain undone. |
We also need to complete updating the new SSP and component models. |
9/5/2019Issue was implemented and is part of PR #476, waiting for @david-waltermire-nist and @brianrufgsa. Schema documentation needs to be reviewed. |
@wendellpiez Although the schema and content changes were made, we still need to update the website documentation to reflect the deletion of subcontrol. We need a new PR for this. |
Worked through documentation yesterday. References to subcontrols still appear in WIP SSP and Component models, to be resolved. Otherwise things are looking more reasonable. The changes are now in the Suggest we do one more grep for |
This was completed in PR #492. |
* Schematron now reports duplicate definitions in a Metaschema as an error: see usnistgov#465, usnistgov#475 * Catalog metaschema and SP800-53 catalog adjustments renaming 'subcontrol' to 'control' per Issue usnistgov#473 * Refactored metaschemas to avoid definition clashes; more/better Schematron to detect such clashes * Adding new module now required by catalog and profile metaschemas * Revising profiles to be valid to newly revised schema (no more references to subcontrol elements only controls) * Bug fix in Metaschema Schematron * Delete FedRAMP_HIGH-baseline_profile.xml * Delete FedRAMP_LOW-baseline_profile.xml * Delete FedRAMP_MODERATE-baseline_profile.xml * Create temp.txt * Revised FedRAMP Profiles These files include revisions to the FedRAMP baselines, plus a small FedRAMP catalog that provides three subcontrols added by FedRAMP. * Delete temp.txt * moved updated fedramp content to correct location * New and improved FedRAMP profiles * Repaired broken markdown conversion; added missing title content to FedRAMP catalog * add note about b -> strong and i -> em (usnistgov#9) * Changed inline markup in FedRAMP profiles for lossless conversion * One more adjustment in Markdown->XML conversion (images) * One more time (cleaning up cleanup)
* Schematron now reports duplicate definitions in a Metaschema as an error: see usnistgov#465, usnistgov#475 * Catalog metaschema and SP800-53 catalog adjustments renaming 'subcontrol' to 'control' per Issue usnistgov#473 * Refactored metaschemas to avoid definition clashes; more/better Schematron to detect such clashes * Adding new module now required by catalog and profile metaschemas * Revising profiles to be valid to newly revised schema (no more references to subcontrol elements only controls) * Bug fix in Metaschema Schematron * Delete FedRAMP_HIGH-baseline_profile.xml * Delete FedRAMP_LOW-baseline_profile.xml * Delete FedRAMP_MODERATE-baseline_profile.xml * Create temp.txt * Revised FedRAMP Profiles These files include revisions to the FedRAMP baselines, plus a small FedRAMP catalog that provides three subcontrols added by FedRAMP. * Delete temp.txt * moved updated fedramp content to correct location * New and improved FedRAMP profiles * Repaired broken markdown conversion; added missing title content to FedRAMP catalog * add note about b -> strong and i -> em (#9) * Changed inline markup in FedRAMP profiles for lossless conversion * One more adjustment in Markdown->XML conversion (images) * One more time (cleaning up cleanup)
User Story:
Most OSCAL users treat subcontrols as controls. Each is actually a functional requirement statement. The use of subcontrol clarifies a logical grouping of related controls. Treatment of control and subcontrol is nearly identical in documentation and automation; however, the use of different syntax requires constant adjustment/alignment of the correct reference (control vs. subcontrol).
We already allow groups within groups, and parts within parts. OSCAL would be simplified, if control enhancements were simply treated as controls within controls, thus replacing the subcontrol element with a nested control element.
This would also allow any depth of nested controls, similar to the way we allow any depth of nested parts.
Goals:
Dependencies:
None
Acceptance Criteria
The text was updated successfully, but these errors were encountered: