Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solidify v1 API and version the API #34

Closed
artasparks opened this issue Jun 1, 2016 · 5 comments
Closed

Solidify v1 API and version the API #34

artasparks opened this issue Jun 1, 2016 · 5 comments
Assignees
Milestone

Comments

@artasparks
Copy link
Member

Related to #31, we should solidify the v1 API and make any API choices before we go into Beta. @duckpunch is currently working on this.

@artasparks artasparks added this to the Beta Launch milestone Jun 1, 2016
@brilee
Copy link
Contributor

brilee commented Jun 1, 2016

versioning is already accomplished here: https://github.com/usgo/online-ratings/blob/master/web/app/__init__.py#L39. Agree with solidifying api design choices.

@duckpunch
Copy link
Collaborator

Agree.

A suggested order of operations:

  1. Go back and forth on semantics, using the docs as the vehicle for discussion. Don't implement anything in code.
  2. Implement the changes after the first step is done.

@artasparks
Copy link
Member Author

@duckpunch -- SGTM.

@brilee brilee self-assigned this Jun 27, 2016
@brilee
Copy link
Contributor

brilee commented Jun 27, 2016

Things that I need to fix, as noted in the docs PR:

  • move auth tokens to headers, instead of queryparams
  • update game server UI's URL to include the server name, rather than the server ID, to make the server's name more discoverable
  • rename or remove the rated field of the Game model. (It was meant to be used to mark whether a game had yet been processed by the ratings algorithm.)
  • remove rated from the Game api - it should not be submitted by the server; it should merely be initialized as False on our end.

@brilee
Copy link
Contributor

brilee commented Jun 27, 2016

(I assigned this issue to myself, but actually, now that I think about it - these are some reasonably easy tasks for somebody new to tackle. It should be a good way to get oriented in the codebase. Let me know if somebody wants to do this.)

@brilee brilee mentioned this issue Jul 21, 2016
@brilee brilee closed this as completed Jul 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants