Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api cleanup #41

Merged
merged 7 commits into from
Jul 21, 2016
Merged

Api cleanup #41

merged 7 commits into from
Jul 21, 2016

Conversation

brilee
Copy link
Contributor

@brilee brilee commented Jul 21, 2016

Making some API changes as discussed in #34

@Kashomon @amj @duckpunch

@brilee
Copy link
Contributor Author

brilee commented Jul 21, 2016

There's some breaking changes in this PR - game_server is renamed server_id and to create a game, you no longer refer to which server it was played on (kgs) but rather than server's ID (1). That server ID is the same one that appears in the UI for online-ratings.

@brilee
Copy link
Contributor Author

brilee commented Jul 21, 2016

Some lingering cleanup - the misleadingly named "rated" field is still in the model, but since it's not exposed anywhere, it should be okay for now. I still have yet to figure out how database migrations work with flask + docker. Since @Kashomon and @TheObtuseAutodidact are working on some new db fields and stuff, we'll need to figure out how to execute DB migrations. We can just delete and recreate the db for now, but when we have real data on the system, that won't fly anymore.

@amj
Copy link
Member

amj commented Jul 21, 2016

Looks great to me. IIUC, we still have a couple basic ops items outstanding:

  • how to deploy (to dev, test, and prod)
  • how do db migrations.

@brilee brilee merged commit 64e17b4 into master Jul 21, 2016
@brilee brilee deleted the api_cleanup branch July 21, 2016 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants