Add support for pandas 2.0 support + lock versions #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgruening
reviewed
Aug 29, 2023
requirements.txt
Outdated
| pyyaml | ||
| requests | ||
| openpyxl | ||
| genshi==0.7.7 |
There was a problem hiding this comment.
I would not pin them that strict, maybe work with >= and <=?
There was a problem hiding this comment.
I agree it is not ideal for people that do not make use of environments, but >= on pandas would not have prevented the issue we now have for example, since certain things will get deprecated. <= would that be better than?
There was a problem hiding this comment.
Both we need bigger than 2.0 and smaller like 3.0 left?
bedroesb
commented
Aug 29, 2023
| @@ -1,6 +1,6 @@ | |||
| genshi | |||
| lxml | |||
| pandas>=1.2 | |||
There was a problem hiding this comment.
@bgruening something like this?
bgruening
approved these changes
Aug 29, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I locked the versions of our requirements to prevent issues. This will close #83