feat: added runner delay #2218
Merged
feat: added runner delay #2218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @therealrinku ! @lohxt1 Can you review this? |
lohxt1
reviewed
May 24, 2024
| </span> | ||
| ) : ( | ||
| <span className="danger text-xs">(request failed)</span> |
There was a problem hiding this comment.
could you also add the onClick handler for the 'request failed' span
onClick={() => setSelectedItem(item)}
lohxt1
reviewed
May 24, 2024
| <div className="mt-6"> | ||
| <label>Delay (in ms)</label> | ||
| <input | ||
| type="text" |
There was a problem hiding this comment.
would you mind changing this to the type 'number'
|
hello, |
|
Merged! Thanks @therealrinku ! |
Its-treason
added a commit
to Its-treason/bruno
that referenced
this pull request
Aug 10, 2024
This was intruced to upstream in usebruno#2218
|
This menu option is not available when executing runner from the collection / run vs Runner top of the screen.
|
1 task
also looking forward for this feature! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added delay time for runner
resolves: #1385
Contribution Checklist:
Screencast.from.2024-05-02.14-25-59.webm