Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tailwindcss-forms): messes up input fields everywhere, removed it #1817

Merged
merged 3 commits into from
Apr 21, 2024

Conversation

bpoulaindev
Copy link
Contributor

Description

Previously added @tailwindcss/forms, but it messes up the global input fields in the UI.
I removed it.
Also solving #1814

image image

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

@riesinger
Copy link

You will also need to update the package-lock.json to resemble the removal of @tailwindcss/forms

@bpoulaindev
Copy link
Contributor Author

Oh yeah i love npm 18s and warnigns everywhere
image

@riesinger
Copy link

It seems like @tailwindcss/forms still wasn't removed from the package-lock.json 🤔

@bpoulaindev
Copy link
Contributor Author

But it's absent from my package-lock.json ... I don't really know how to solve this, except by rebuilding my entire package lock

@riesinger
Copy link

Sorry, I just looked at the diff. And you're right, @tailwindcss/forms hasn't been in the package-lock.json.

@helloanoop helloanoop merged commit 54e99cb into usebruno:main Apr 21, 2024
3 checks passed
lizziemac pushed a commit to lizziemac/bruno that referenced this pull request May 4, 2024
…usebruno#1817)

* fix(tailwindcss-forms): messes up input fields everywhere, removed it
* fix(tailwindcss-form): update package-lock.json
---------
Co-authored-by: bpoulaindev <[email protected]>
Co-authored-by: Anoop M D <[email protected]>
jwetzell pushed a commit to jwetzell/bruno that referenced this pull request Aug 2, 2024
…usebruno#1817)

* fix(tailwindcss-forms): messes up input fields everywhere, removed it
* fix(tailwindcss-form): update package-lock.json
---------
Co-authored-by: bpoulaindev <[email protected]>
Co-authored-by: Anoop M D <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants