Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some definitions and tests #214

Merged
merged 2 commits into from
Aug 10, 2018
Merged

Conversation

annekainicUSDS
Copy link
Contributor

Description

Some definitions are probably too specific to a certain type of schema to be generally useful. Move these ones back into vets-website.

Accompanying vets-website PR: department-of-veterans-affairs/vets-website#8149

@annekainicUSDS annekainicUSDS changed the title WIP Remove some definitions and tests Remove some definitions and tests Aug 9, 2018
@annekainicUSDS annekainicUSDS merged commit de12414 into master Aug 10, 2018
@annekainicUSDS annekainicUSDS deleted the extract-definitions-1 branch August 10, 2018 13:15
@annekainicUSDS
Copy link
Contributor Author

Just realized I didn't run the build on this PR, oops! Perhaps we want to check our pre commit hook because I think that should have caught it. I'll submit a separate PR with those changes.

@annekainicUSDS annekainicUSDS restored the extract-definitions-1 branch August 10, 2018 13:50
@annekainicUSDS annekainicUSDS deleted the extract-definitions-1 branch August 10, 2018 14:16
bernars-usa added a commit that referenced this pull request Aug 10, 2018
bernars-usa added a commit that referenced this pull request Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants