Import definitions from usfs #8149
Conversation
annekainicUSDS
force-pushed
the
import-definitions-from-usfs
branch
from
533f653
to
a05e574
Compare
annekainicUSDS
changed the title
| import environment from '../../../platform/utilities/environment'; | ||
|
|
||
| import * as address from 'us-forms-system/lib/js/definitions/address'; | ||
| import fullNameUI from 'us-forms-system/lib/js/definitions/fullName'; |
There was a problem hiding this comment.
It looks like we're missing a replacement of us-forms-system/lib/js/definitions/fullName and us-forms-system/lib/js/definitions/personId in src/platform/forms/pages/applicantInformation.jsx?
There was a problem hiding this comment.
Ah thanks, I missed those!
annekainicUSDS
force-pushed
the
import-definitions-from-usfs
branch
from
a05e574
to
75e484e
Compare
|
@cehsu @rianfowler for some reason I'm now getting an issue where it's saying that the |
|
Looks like that lint error is happening on master as well, so perhaps it was introduced by a different PR? |
|
@annekainicUSDS We had a merge collision that was resolved improperly. I've just merged the fix- you should now be able to pull master and successfully build. |
annekainicUSDS
force-pushed
the
import-definitions-from-usfs
branch
from
75e484e
to
5fe761c
Compare
We're moving some of the definitions that are pretty specific and potentially not generally usable back into vets-website. This is the first pass at doing that.
Accompanying PR on USFS: usds/us-forms-system#214