Remove "optional: true" from inputs of publish service artifacts reusable workflow #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulucinar
force-pushed
the
fix-ssop
branch
8 times, most recently
from
6c1d052
to
e7cf372
Compare
ulucinar
changed the title
ulucinar
changed the title
1 task
ulucinar
commented
May 12, 2023
| @@ -42,7 +42,7 @@ env: | |||
|
|
|||
| jobs: | |||
| index: | |||
| runs-on: [e2-standard-8, linux] | |||
There was a problem hiding this comment.
To be reverted back before being merged. Had to replace the runners to be able to test.
jeanduplessis
approved these changes
May 13, 2023
…ifacts Signed-off-by: Alper Rifat Ulucinar <[email protected]>
|
We are observing the following error but my understanding is this is because the test PR calls the reusable workflow from a different organization. Thus my expectation is this will go away when the provider-gcp PR starts calling the reusable workflow from under the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Relevant PR: crossplane-contrib/provider-upjet-gcp#302
The PR fixes an issue with the
Publish Service ArtifactsGithub workflow, where an invalidoptional: truefield exists in theconcurrencyinput.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Please see crossplane-contrib/provider-upjet-gcp#302 and https://github.com/upbound/provider-gcp/actions/runs/4963402570.