Fix Publish Service Artifacts workflow call #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulucinar
commented
May 12, 2023
|
|
||
| jobs: | ||
| publish-service-artifacts: | ||
| uses: upbound/uptest/.github/workflows/provider-publish-service-artifacts.yml@main | ||
| uses: ulucinar/uptest/.github/workflows/provider-publish-service-artifacts.yml@fix-ssop |
There was a problem hiding this comment.
To be reverted back once the uptest PR is merged.
1 task
jeanduplessis
approved these changes
May 13, 2023
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
ulucinar
force-pushed
the
test-uptest-pr-110
branch
from
c3d196a
to
3f34107
Compare
|
Looks like with the larger runners, we are able to achive a concurrency of ~4 (# of batches x batch concurrency) while pushing to the registry (when there's only one family being built & pushed): https://github.com/upbound/provider-gcp/actions/runs/4973387477 Here'a another run of concurrency ~6: https://github.com/upbound/provider-gcp/actions/runs/4973546523/jobs/8899466534 Timings from these runs:
As we increase concurrency, the error rate at the registry and the total number of retries increase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Relevant PR: upbound/official-providers-ci#110
This PR removes the
optional: truespecification in the inputs of thePublish Service Artifactsreusable workflow call and converts types ofsizeandconcurrencyinput parameters fromnumbertostring.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Please see: https://github.com/upbound/provider-gcp/actions/runs/4963402570