This repository has been archived by the owner on May 30, 2024. It is now read-only.
Support skipping dependency resolution of installed Crossplane packages in target local.xpkg.init #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es in target local.xpkg.init Signed-off-by: Alper Rifat Ulucinar <[email protected]>
ulucinar
requested review from
turkenh,
pedjak,
phisco,
ezgidemirel and
lsviben
as code owners
phisco
reviewed
Sep 29, 2023
1 task
…pkg.deploy.provider.% This is because the package's image is specified in the ControllerConfig it refers to. Signed-off-by: Alper Rifat Ulucinar <[email protected]>
phisco
approved these changes
Oct 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
In the context of official provider testing, we would like to be able to run uptest using the family providers instead of the monolithic providers to avoid the CRD scaling issues we've been observing with them. Each resource provider in a provider family declares a package dependency to the family's config provider and the Crossplane RBAC manager is responsible for assigning the required RBAC rules on the config provider resources for the ClusterRole assigned to the family resource provider's K8s ServiceAccount. However, the RBAC manager refuses to do so if the reg/org of the resource provider's package does not match the config provider package's.
This PR proposes to make the dependency installation optional for the
local.xpkg.inittarget so that while running uptests, we can manually install the config provider from the cache.I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested
Tested against
upbound/provider-awsin PR crossplane-contrib/provider-upjet-aws#903.