Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uptest family providers #903

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

ulucinar
Copy link
Collaborator

@ulucinar ulucinar commented Oct 2, 2023

Description of your changes

Depends on: upbound/build#241

Currently when an e2e test is triggered in upbound/provider-aws, the test is run with the monolithic provider (upbound/provider-aws) package built from the feature branch.

This omits the family resource providers (not a problem from the resource configuration validation perspective because both the monolith and the corresponding resource provider utilize the same resource configuration) but the built family resource package itself is not tested).

Another issue that's the main motivation of the proposed changes in this PR is that the number of CRDs installed with the monolithic package cause noise in the tests (pod restarts, timeouts at various levels, etc.).

This PR proposes to switch to the family resource providers when running uptests in this repo.

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Tested locally by running:

...
export UPTEST_EXAMPLE_LIST="examples/iam/role.yaml,,examples/iam/user.yaml,,examples/iam/policy.yaml,,examples/ec2/vpc.yaml,"
make e2e

Note: Common dependencies in the above example manifest list may cause testing issues unrelated to this PR. cc. @turkenf, who also confirmed similar findings with the dependencies. We've long been discussing a shared catalog of dependencies from which dependencies can be injected into the dependent example manifests with the help of an uptest preprocessor. This is not in the scope of this PR as mentioned.

Also tested with the following uptest runs:

...
17:10:35 [ .. ] Building and deploying resource providers for the short API groups: config,ec2,sfn,iam,
...
17:11:19 [ .. ] Batch processing smaller provider packages for: config ec2 sfn iam 
...
17:12:47 [ OK ] deploying provider package provider-aws-config v0.0.0-3.gcc29e5c
...
17:13:02 [ OK ] deploying provider package provider-aws-ec2 v0.0.0-3.gcc29e5c
...
17:13:26 [ OK ] deploying provider package provider-aws-sfn v0.0.0-3.gcc29e5c
...
17:13:43 [ OK ] deploying provider package provider-aws-iam v0.0.0-3.gcc29e5c
...

Also verified the metadata of the provider packages produced by:

make SUBPACKAGES="iam config" BRANCH_NAME=main XPKG_REG_ORGS=index.docker.io/ulucinar build.all publish

@ulucinar ulucinar force-pushed the uptest-family-providers branch 2 times, most recently from 0dad367 to 7b94bd1 Compare October 2, 2023 13:18
@ulucinar ulucinar force-pushed the uptest-family-providers branch 2 times, most recently from 44290e9 to 8aefe41 Compare October 2, 2023 14:54
@ulucinar
Copy link
Collaborator Author

ulucinar commented Oct 2, 2023

/test-examples="examples/ec2/vpc.yaml"

@ulucinar
Copy link
Collaborator Author

ulucinar commented Oct 2, 2023

/test-examples="examples/ec2/vpc.yaml"

@ulucinar
Copy link
Collaborator Author

ulucinar commented Oct 2, 2023

/test-examples="examples/ec2/vpc.yaml"

@ulucinar
Copy link
Collaborator Author

ulucinar commented Oct 2, 2023

/test-examples="examples/ec2/vpc.yaml"

@ulucinar
Copy link
Collaborator Author

ulucinar commented Oct 2, 2023

/test-examples="examples/ec2/vpc.yaml"

@ulucinar
Copy link
Collaborator Author

ulucinar commented Oct 2, 2023

/test-examples="examples/ec2/vpc.yaml,examples/iam/role.yaml"

@ulucinar
Copy link
Collaborator Author

ulucinar commented Oct 2, 2023

/test-examples="examples/ec2/vpc.yaml,examples/sfn/statemachine.yaml"

Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ulucinar LGTM!

@ulucinar ulucinar merged commit 978183f into crossplane-contrib:main Oct 3, 2023
8 checks passed
@ulucinar ulucinar deleted the uptest-family-providers branch October 3, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants