-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uptest family providers #903
Uptest family providers #903
Conversation
0dad367
to
7b94bd1
Compare
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
44290e9
to
8aefe41
Compare
/test-examples="examples/ec2/vpc.yaml" |
8aefe41
to
e4e036f
Compare
/test-examples="examples/ec2/vpc.yaml" |
e4e036f
to
1644f14
Compare
/test-examples="examples/ec2/vpc.yaml" |
1644f14
to
d4974f8
Compare
/test-examples="examples/ec2/vpc.yaml" |
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
d4974f8
to
cc29e5c
Compare
/test-examples="examples/ec2/vpc.yaml" |
/test-examples="examples/ec2/vpc.yaml,examples/iam/role.yaml" |
/test-examples="examples/ec2/vpc.yaml,examples/sfn/statemachine.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ulucinar LGTM!
Description of your changes
Depends on: upbound/build#241
Currently when an e2e test is triggered in
upbound/provider-aws
, the test is run with the monolithic provider (upbound/provider-aws
) package built from the feature branch.This omits the family resource providers (not a problem from the resource configuration validation perspective because both the monolith and the corresponding resource provider utilize the same resource configuration) but the built family resource package itself is not tested).
Another issue that's the main motivation of the proposed changes in this PR is that the number of CRDs installed with the monolithic package cause noise in the tests (pod restarts, timeouts at various levels, etc.).
This PR proposes to switch to the family resource providers when running uptests in this repo.
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Tested locally by running:
Note: Common dependencies in the above example manifest list may cause testing issues unrelated to this PR. cc. @turkenf, who also confirmed similar findings with the dependencies. We've long been discussing a shared catalog of dependencies from which dependencies can be injected into the dependent example manifests with the help of an uptest preprocessor. This is not in the scope of this PR as mentioned.
Also tested with the following uptest runs:
ec2
)ec2
,iam
), one group per fileec2
,iam
,sfn
), where a single example manifest file contains the two groupsiam
andsfn
:Also verified the metadata of the provider packages produced by:
make SUBPACKAGES="iam config" BRANCH_NAME=main XPKG_REG_ORGS=index.docker.io/ulucinar build.all publish