fix: avoid serializing body with buffer type #273
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
resolves #269
β Type of change
π Description
Normally we allow serializing pure objects (with object constructor) OR classes that implement
toJSON()
.However Buffer type is different and implements a
toJSON
method which is mainly for debugging.This PR detects buffer type without depending on global
Buffer
as (Node.js) workaroundNote: Worth to mention that other
BodyInit
compatible types such asUInt8Array
do not share this issue as do not implementtoJSON
. We might consider detecting them explicitly if any runtime in the feature does. (-- Investigating Readable Body stream in next steps, current check currently allows it to be unserialized --)π Checklist