Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: automatically enable duplex to stream request body #275

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Aug 23, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR enables to support of stream request bodies (ReadableStream and Readable) out of the box by setting (semi standard?!) duplex: 'half' option.

Limitations:

  • This feature is only supported with native node fetch (Node.js 18+)
  • For some reason, i couldn't enable "transformed-encoding": "chunked" and was causing the unsupported error. Therefore in tests, an explicit content-length is set (which i guess ideally we should not need)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 merged commit d58b961 into main Aug 23, 2023
4 checks passed
@pi0 pi0 deleted the feat/readable-body branch August 23, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant