Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reimplements server with h3 #168

Merged
merged 9 commits into from
Sep 14, 2023
Merged

feat: reimplements server with h3 #168

merged 9 commits into from
Sep 14, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Sep 13, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR reimplements middleware as a new server powered by h3 utils and adapters which will be maintained upstream for best platform compatibility and stability.

As part of this refactor, API has a few breaking changes and some features might be dropped initially.

New exports:

  • createIPXH3Handler(ipx)
  • createIPXH3App(ipx)
  • createIPXWebServer(ipx)
  • createIPXNodeServer(ipx)
  • createIPXPlainServer(ipx)

TODO:

  • Make sure there are no security issues by removing dependency on xss ~> h3
  • Use H3 errors
  • Try to support back per instance global options (or alternatively move to ipx core)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 marked this pull request as ready for review September 14, 2023 20:50
@pi0 pi0 merged commit 1f14c2e into v1 Sep 14, 2023
1 check passed
@pi0 pi0 deleted the feat/h3 branch September 14, 2023 20:51
@pi0 pi0 mentioned this pull request Sep 14, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant