Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

building on lts-20.22 (ghc 9.2.7) #4016

Merged
merged 9 commits into from
May 24, 2023
Merged

building on lts-20.22 (ghc 9.2.7) #4016

merged 9 commits into from
May 24, 2023

Conversation

aryairani
Copy link
Contributor

@aryairani aryairani commented May 23, 2023

Pins network-3.1.2.7 (the default network-3.1.3.0 doesn't build in Windows) and a custom older build of haskeline (we can maybe carefully replay other haskeline PRs or leave it alone for now).

LTS 20.22 is the latest LTS.

Overview

Builds on #3304 and #3642. Windows haskeline bugs killed the previous attempt.

closes #3945 (new commit is unisonweb/haskeline@9275eea)
closes #3034 (or at least can't repro)

Implementation notes

To fix Windows haskeline, I took our existing now-off-branch haskeline commit, updated it for the new LTS, and pushed it to https://github.com/unisonweb/haskeline/tree/unison-23-05-20, which is not a very good name, but it's better than no name.
Thing that didn't work last time: Take the latest version of haskeline and apply the patch we thought was needed to make ANSI work. Something new has changed in haskeline to make this insufficient or totally wrong.

Test coverage

Manually checked the ANSI prompt in Windows (pic is of vscode embedded terminal):
image

Loose ends

  1. I had to turn use {-# OPTIONS_GHC -Wno-incomplete-uni-patterns #-} here and there to build successfully with GHC 9.2.7. Tagging people who last modified the code in question:
  • parser-typechecker/src/Unison/PatternMatchCoverage/Solve.hs cc @tstat
  • unison-share-api/src/Unison/Server/Doc.hs cc @ChrisPenner
  1. If we want to update to a newer haskeline than this 8.0.0, we'll have to carefully replay the commits to get there. :-\

@mergify
Copy link
Contributor

mergify bot commented May 23, 2023

⚠️ The sha of the head commit of this PR conflicts with #4008. Mergify cannot evaluate rules on this PR. ⚠️

@aryairani aryairani changed the title building on lts-20.22 building on lts-20.22 (ghc 9.2.7) May 24, 2023
@aryairani aryairani marked this pull request as ready for review May 24, 2023 15:26
@@ -2,8 +2,6 @@ flags:
haskeline:
terminfo: false

allow-newer: true # async package has needlessly strict upper bound
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@aryairani aryairani merged commit 143c0de into trunk May 24, 2023
@aryairani aryairani deleted the lts-20.22 branch May 24, 2023 20:43
@ChrisPenner
Copy link
Contributor

I suppose this will need to be updated at some point now: https://github.com/unisonweb/unison/blob/trunk/docs/m1-mac-setup-tips.markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get off the off-repo commit for judah/haskeline? Windows Terminal with Windows CMD eats characters
4 participants