-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
building on lts-20.22 (ghc 9.2.7) #4016
Merged
+89
−201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
1 task
pchiusano
approved these changes
May 24, 2023
@@ -2,8 +2,6 @@ flags: | |||
haskeline: | |||
terminfo: false | |||
|
|||
allow-newer: true # async package has needlessly strict upper bound |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
mitchellwrosen
approved these changes
May 24, 2023
I suppose this will need to be updated at some point now: https://github.com/unisonweb/unison/blob/trunk/docs/m1-mac-setup-tips.markdown |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pins
network-3.1.2.7
(the defaultnetwork-3.1.3.0
doesn't build in Windows) and a custom older build ofhaskeline
(we can maybe carefully replay otherhaskeline
PRs or leave it alone for now).LTS 20.22 is the latest LTS.
Overview
Builds on #3304 and #3642. Windows haskeline bugs killed the previous attempt.
closes #3945 (new commit is unisonweb/haskeline@9275eea)
closes #3034 (or at least can't repro)
Implementation notes
To fix Windows haskeline, I took our existing now-off-branch haskeline commit, updated it for the new LTS, and pushed it to https://github.com/unisonweb/haskeline/tree/unison-23-05-20, which is not a very good name, but it's better than no name.
Thing that didn't work last time: Take the latest version of haskeline and apply the patch we thought was needed to make ANSI work. Something new has changed in haskeline to make this insufficient or totally wrong.
Test coverage
Manually checked the ANSI prompt in Windows (pic is of vscode embedded terminal):
Loose ends
{-# OPTIONS_GHC -Wno-incomplete-uni-patterns #-}
here and there to build successfully with GHC 9.2.7. Tagging people who last modified the code in question:unison-share-api/src/Unison/Server/Doc.hs cc @ChrisPenner✅