Get off the off-repo commit for judah/haskeline?

[philderbeast]

Could we update the commit hash for the source repository package haskell/haskeline@d6c2643 to one within the repo or go with a release? Off-repo commits like this can disappear.

This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

unison/stack.yaml

Lines 59 to 61 in 3225634

	# https://github.com/judah/haskeline/pull/126
	- github: judah/haskeline
	commit: d6c2643b0d5c19be7e440615c6f84d603d4bc648

[philderbeast]

A related fork and branch for the PR is mpilgrem/haskeline/fix88.

[jneira]

hi, want to note it is blocking somewhat the contrib build config for cabal (you cant use stale commits with source-repository-package)

[philderbeast]

Yes @jneira, this is exactly what alerted me to the problem (while dusting off the cabal project):

$ cabal build all --enable-tests --enable-benchmarks --project-file=contrib/cabal.project
Cloning into '.../unison/dist-newstyle/src/haskeline-6450a1727d5db11c'...
remote: Enumerating objects: 5057, done.
remote: Counting objects: 100% (91/91), done.
remote: Compressing objects: 100% (53/53), done.
remote: Total 5057 (delta 44), reused 71 (delta 32), pack-reused 4966
Receiving objects: 100% (5057/5057), 1.19 MiB | 8.73 MiB/s, done.
Resolving deltas: 100% (2425/2425), done.
fatal: Could not parse object 'd6c2643b0d5c19be7e440615c6f84d603d4bc648'.

[jneira]

just in case I tried to update cabal config here: #3722 (comment)

[aryairani]

We can try any commit that works; but we don't have any automated tests for making sure that haskeline is working right, so I'm always hesitant to make changes.

Could someone create a PR and test things out (include some screenshots) on Mac, Windows, Linux? I can volunteer to test on Mac.

[ceedubs]

Would it be easier to point to https://github.com/unisonweb/haskeline instead of the main haskeline repo?

[aryairani]

@ceedubs Yes we can do that again. We briefly had a usable build on their repo, but then I guess they moved the branch head to one that didn't include the commit :headdesk: