-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transformers take VFile instead of VFileCompatible #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
/cc @Rokt33r |
ChristianMurphy
approved these changes
Jul 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rokt33r
approved these changes
Jul 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes sense to me. Thanks for the contributing!!! ❤️
I guess this can be deployed as a patch release because it is a kind of bug fix. |
wooorm
approved these changes
Jul 16, 2019
wooorm
pushed a commit
to remarkjs/remark
that referenced
this pull request
Jul 20, 2019
Related to unifiedjs/unified#53. Related to unifiedjs/unified#54. Related to unifiedjs/unified#56. Related to unifiedjs/unified#57. Related to unifiedjs/unified#58. Related to unifiedjs/unified#59. Related to unifiedjs/unified#60. Related to unifiedjs/unified#61. Related to unifiedjs/unified#62. Related to unifiedjs/unified#63. Related to unifiedjs/unified#64. Related to #426. Reviewed-by: Titus Wormer <[email protected]> Reviewed-by: Junyoung Choi <[email protected]> Reviewed-by: Christian Murphy <[email protected]> Co-authored-by: Junyoung Choi <[email protected]> Co-authored-by: Christian Murphy <[email protected]>
wooorm
added
☂️ area/types
This affects typings
⛵️ status/released
🐛 type/bug
This is a problem
👶 semver/patch
This is a backwards-compatible fix
labels
Aug 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
☂️ area/types
This affects typings
💪 phase/solved
Post is done
👶 semver/patch
This is a backwards-compatible fix
🐛 type/bug
This is a problem
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the types for this package define that Transformers accept a
file
parameter that isVFileCompatible
. The spec, on the other hand, states the type of thefile
parameter is aVFile
.The current definition is unergonomic because a plugin defined as:
...cannot be passed to
use
sincefile: VFile
is incompatible withfile: VFileCompatible
(ironically):causes:
Even more, existing plugins built on the unified spec expect a
VFile
to be passed without needing to coerce the passed value into aVFile
, making the current definition inaccurate for these plugins.This PR fixes this issue by adding some basic tests that make sure this pattern works with
use
& making the necessary 10-character removal to make them pass.