-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add descriptions and type params to tsdoc #61
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianMurphy
commented
Jul 12, 2019
ChristianMurphy
commented
Jul 12, 2019
/cc @Rokt33r |
This comment has been minimized.
This comment has been minimized.
Rokt33r
requested changes
Jul 13, 2019
ChristianMurphy
force-pushed
the
docs/generic-tsdoc
branch
from
July 13, 2019 13:51
2eb7ba0
to
7fd8690
Compare
Remove unused generic and merge PluginTriple into PluginTuple
ChristianMurphy
force-pushed
the
docs/generic-tsdoc
branch
from
July 13, 2019 13:55
7fd8690
to
99fd99f
Compare
Rokt33r
approved these changes
Jul 13, 2019
wooorm
approved these changes
Jul 13, 2019
wooorm
pushed a commit
to remarkjs/remark
that referenced
this pull request
Jul 20, 2019
Related to unifiedjs/unified#53. Related to unifiedjs/unified#54. Related to unifiedjs/unified#56. Related to unifiedjs/unified#57. Related to unifiedjs/unified#58. Related to unifiedjs/unified#59. Related to unifiedjs/unified#60. Related to unifiedjs/unified#61. Related to unifiedjs/unified#62. Related to unifiedjs/unified#63. Related to unifiedjs/unified#64. Related to #426. Reviewed-by: Titus Wormer <[email protected]> Reviewed-by: Junyoung Choi <[email protected]> Reviewed-by: Christian Murphy <[email protected]> Co-authored-by: Junyoung Choi <[email protected]> Co-authored-by: Christian Murphy <[email protected]>
wooorm
added
☂️ area/types
This affects typings
⛵️ status/released
🦋 type/enhancement
This is great to have
🧒 semver/minor
This is backwards-compatible change
labels
Aug 10, 2019
wooorm
changed the title
docs: add descriptions and type params to tsdoc
Add descriptions and type params to tsdoc
Aug 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
☂️ area/types
This affects typings
💪 phase/solved
Post is done
🧒 semver/minor
This is backwards-compatible change
🦋 type/enhancement
This is great to have
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes unused generic and merges PluginTriple into PluginTuple
These are fixes, no features added in this PR.