Ensure we have comprehensive coverage for the ICU4X bug #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Markus Scherer <[email protected]>
…odetools into normalization-woes
markusicu
reviewed
Jan 23, 2024
unicodetools/src/main/java/org/unicode/text/UCD/GenerateData.java
Outdated
Show resolved
Hide resolved
markusicu
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #658, #656.
@hsivonen pointed out to me that they have a special code path for the non-BMP case that is currently unused. This ensures that, should we ever encode a decomposition to which it applies, the tests would exercise that.