Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test decomposition that contain more than one starter and ends with a non-starter followed by low-CCC non-starter #656

Closed
hsivonen opened this issue Jan 18, 2024 · 1 comment · Fixed by #658
Assignees

Comments

@hsivonen
Copy link
Member

ICU4X had a bug in the normalizer for the case where a character whose decomposition contains more than one starter and ends with a non-starter is followed by a non-starter whose CCC is lower than the final non-starter of the decomposition.

I had thought about this case, but I had failed to type a ! for logical negation of a condition and the test suite didn't catch this.

NormalizationTest.txt should include cases like this. Known examples:

  • NFKD of 01C4 0323
  • NFD of 0DDD 0334
@hsivonen
Copy link
Member Author

CC @eggrobin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants