Regenerate UnicodeData in MakeUnicodeFiles; fix a bug in Unicode_1_Name #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turned out much easier than expected, because Mark had done half the work twenty years ago. This should make the processing of new proposals easier: no need to manually merge-sort the lines from the proposal, and with #444, conflict markers will be automatically eliminated when regenerating the UCD.
This also fixes a (fairly uninteresting) bug: the Unicode_1_Name property (obsolete, but neither deprecated nor stabilized, and importantly not blanked like ISO_Comment was) was incorrectly handled by the tools, which relied on an ICU API for it (ICU deprecated that API in ICU-9013, unicode-org/icu@c39e5af).
The new options for BagFormatter should allow us to generate files without spaces either side of the semicolon, like the 15.0 and earlier LB and EAW, should that be needed.
The function
dumbFractionis extended to guess the correct denominator based on the name; if we want the fraction fields in DerivedNumericValues to match UnicodeData for the Meroitic cursive twelfths, we could pass the name there too; for now I am leaving the data files unchanged.