Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore conflict markers in ConvertUCD #444

Merged
merged 13 commits into from
May 2, 2023

Conversation

eggrobin
Copy link
Member

We might need to do that for other parsers at some point; this is the only one that posed problems when merging #442 and #441.

Note that after merging and before running MakeUnicodeFiles, the Derived files need to be reset to a non-conflicting state, otherwise the ranges either side of the conflict markers overlap. UnicodeData is obviously immune to that.

This will probably be a problem for some source files eventually (LineBreak or Script), so I am leaving #419 open; we’ll cross that bridge when we get to it.

@eggrobin
Copy link
Member Author

eggrobin commented Apr 18, 2023

Tested with five of the pipeline PRs:
The last four commits on https://github.com/eggrobin/unicodetools/commits/deconfliction-test are all mindlessly produced by:

  1. merge;
  2. checkout the Derived* and extracted/* at HEAD;
  3. regenerate the UCD;
  4. commit.

@eggrobin
Copy link
Member Author

mindlessly

A little bit too mindlessly even, since of course this process retains all conflict markers in UnicodeData.txt!

@eggrobin
Copy link
Member Author

Alright, trying again now that UnicodeData is regenerated: the last 5 commits of https://github.com/eggrobin/unicodetools/commits/deconfliction-test were produced by:

foreach ($branch in @('170-C7', '170-C15', '170-C17', '172-C3', '171-C13')) {
  git fetch origin;
  git merge origin/$branch;
  git checkout HEAD unicodetools/data/ucd/dev/Derived*;
  git checkout HEAD unicodetools/data/ucd/dev/extracted/*;
  git checkout HEAD unicodetools/data/ucd/dev/auxiliary/*;
  rm .\Generated\* -recurse -force;
  mvn compile exec:java '-Dexec.mainClass="org.unicode.text.UCD.Main"'  '-Dexec.args="build MakeUnicodeFiles"' -am -pl unicodetools  "-DCLDR_DIR=..\cldr\"  "-DUNICODETOOLS_GEN_DIR=Generated"  "-DUNICODETOOLS_REPO_DIR=.";
  cp .\Generated\UCD\15.1.0\* .\unicodetools\data\ucd\dev -recurse -force;
  rm unicodetools\data\ucd\dev\zzz-unchanged-*;
  rm unicodetools\data\ucd\dev\*\zzz-unchanged-*;
  rm .\unicodetools\data\ucd\dev\extra\*;
  rm .\unicodetools\data\ucd\dev\cldr\*;
  git commit -am "merge $branch";
}

@eggrobin eggrobin requested review from macchiati and markusicu April 20, 2023 22:23
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm -- nice! looking forward to see it in live action :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants