Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new_from_data for FixedDecimalFormat #933

Closed
wants to merge 1 commit into from

Conversation

Manishearth
Copy link
Member

Progress on #560

@sffc the constructor for DateTimeFormat is a bit more complicated, what would you like its constructor to look like?

Also, you've mentioned in the past that we should make PluralRulesList the data format for PluralRules. Anything I should know to start doing this?

@Manishearth Manishearth requested a review from a team as a code owner August 4, 2021 20:46
@Manishearth Manishearth requested a review from sffc August 4, 2021 20:46
@coveralls
Copy link

Pull Request Test Coverage Report for Build 37b7a9f1af39432b6fa8cbadae94a4cdd9519cba-PR-933

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 75.061%

Changes Missing Coverage Covered Lines Changed/Added Lines %
components/decimal/src/lib.rs 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
experimental/provider_ppucd/src/parse_ppucd.rs 1 93.28%
Totals Coverage Status
Change from base Build ae65821858b61560d984c28e2c2153ae39e087e2: -0.03%
Covered Lines: 9535
Relevant Lines: 12703

💛 - Coveralls

@Manishearth Manishearth closed this Aug 4, 2021
@Manishearth Manishearth deleted the new-from-data branch February 3, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants