Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

capi: Separate data loading from ICU4X APIs #560

Closed
Manishearth opened this issue Mar 19, 2021 · 3 comments
Closed

capi: Separate data loading from ICU4X APIs #560

Manishearth opened this issue Mar 19, 2021 · 3 comments
Assignees
@Manishearth
Labels
A-ffi Area: FFI, WebAssembly, Transpilation C-data-infra Component: provider, datagen, fallback, adapters C-ffi-infra Component: Diplomat, horizontal FFI R-obsolete Resolution: This issue is no longer relevant S-medium Size: Less than a week (larger bug fix or enhancement) T-core Type: Required functionality
Milestone
ICU4X 0.4

Comments

@Manishearth
Copy link
Member

Followup of #552

See https://github.com/unicode-org/icu4x/blob/68d6b2bdcfbf36c7d25848a71009a2159ea3d780/docs/research/wrapper_layer.md

We should improve our APIs to expose lower level "you do the data loading for me" APIs such that they can be exposed at the FFI level.

This is technically possible already by writing one-off data providers that are capable of only providing the data you have already loaded, but this is more of a hack.

There are two steps to this:

  • Add lower level construction APIs for PluralRules, etc which take in their required data objects
  • Expose these to the C API
@Manishearth Manishearth added the A-ffi Area: FFI, WebAssembly, Transpilation label Mar 19, 2021
@Manishearth Manishearth mentioned this issue Mar 19, 2021
Merged
3 tasks
@Manishearth Manishearth self-assigned this Mar 25, 2021
@Manishearth Manishearth mentioned this issue Mar 25, 2021
Merged
@sffc sffc added this to the ICU4X 0.3 milestone Apr 19, 2021
@sffc sffc added C-data-infra Component: provider, datagen, fallback, adapters S-medium Size: Less than a week (larger bug fix or enhancement) T-core Type: Required functionality labels Apr 19, 2021
@sffc
Copy link
Member

sffc commented Apr 19, 2021

Related: #663

@Manishearth
Copy link
Member Author

This is currently blocked on all of the DataPayload refactorings (#667)

@sffc sffc added the C-ffi-infra Component: Diplomat, horizontal FFI label Jun 16, 2021
@Manishearth Manishearth modified the milestones: ICU4X 0.3, ICU4X 0.4 Jul 14, 2021
@Manishearth Manishearth mentioned this issue Aug 4, 2021
Closed
@Manishearth
Copy link
Member Author

Given the plans for async data providers we don't need to do this anymore

@sffc sffc added the R-obsolete Resolution: This issue is no longer relevant label Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Manishearth Manishearth

Labels
A-ffi Area: FFI, WebAssembly, Transpilation C-data-infra Component: provider, datagen, fallback, adapters C-ffi-infra Component: Diplomat, horizontal FFI R-obsolete Resolution: This issue is no longer relevant S-medium Size: Less than a week (larger bug fix or enhancement) T-core Type: Required functionality
Projects
None yet
Milestone
ICU4X 0.4
Development

No branches or pull requests
2 participants
@sffc @Manishearth