Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-18028 Fix final items in spec before release #4135

Open
wants to merge 4 commits into
base: maint/maint-46
Choose a base branch
from

Conversation

macchiati
Copy link
Member

@macchiati macchiati commented Oct 16, 2024

CLDR-18028

Includes

  • Updates to the terms of use and status for each section.
  • Deletion of some outdated notes in summaries (eg, "some links may lead to in-development ...")
  • In tr35.md, also:
    • reworded the explanation of the relationship between Unicode BCP 47 locale identifier and_BCP 47 language tag_, also adding 2 links for more information
    • fixed typos

This does not do the final adjustments before release:

  • changing |Version|46 (draft) | to |Version|46 |

  • Hiding _This is a draft document… and unhiding _This document has been…

  • Fixing the TOC

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

srl295
srl295 previously approved these changes Oct 16, 2024
Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM did we already mark it as stable?

@macchiati
Copy link
Member Author

Mark "it" as stable?

BTW, this is the first of several commits; this part is mostly updating the TOU, but there are other items from the TC meeting. I also left a question in slack.

@AEApple
Copy link
Contributor

AEApple commented Oct 16, 2024

I still don't see the fix for the mispelling of 'useage' in the modifications section. I haven't finished checking the others yet. Are all the edits from the TC meeting about the mods section expected to be included in this PR?

@macchiati
Copy link
Member Author

This is still draft, so I don't have all the fixes in from the meeting yet. Once I do I'll mark it as 'ready for review'.

@macchiati macchiati marked this pull request as ready for review October 16, 2024 20:21
@macchiati
Copy link
Member Author

Just made "Ready for review". Added notes in the Description for what was done.

I'll leave the ticket open for the later work, but we can merge this PR.

@macchiati
Copy link
Member Author

Note: for some reason the Rich Text button fails, with:

Oh My
Sorry, we’re unable to render a diff of this document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants